diff options
| author | tzik <tzik@chromium.org> | 2016-02-11 02:24:45 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-02-11 10:26:28 +0000 |
| commit | 9ca3021996e87ad03adf4451fd7fc7f8097c8f46 (patch) | |
| tree | a1c2fd07c8ea0858cbd6880c834a57ed1a6eadb1 /styleguide | |
| parent | fbcb7dcadf19f4c20217365b3af0a34d66511b49 (diff) | |
| download | chromium_src-9ca3021996e87ad03adf4451fd7fc7f8097c8f46.zip chromium_src-9ca3021996e87ad03adf4451fd7fc7f8097c8f46.tar.gz chromium_src-9ca3021996e87ad03adf4451fd7fc7f8097c8f46.tar.bz2 | |
Replace base::Tuple implementation with std::tuple
* Remove base::Tuple and make base::Tuple as an alias of std::tuple.
* Expand the alias where it's used in a class template specialization to avoid MSVC2013 internal compiler error.
BUG=554987
Review URL: https://codereview.chromium.org/1673563002
Cr-Commit-Position: refs/heads/master@{#374878}
Diffstat (limited to 'styleguide')
| -rw-r--r-- | styleguide/c++/c++11.html | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/styleguide/c++/c++11.html b/styleguide/c++/c++11.html index 27d37b6..7c3a42c 100644 --- a/styleguide/c++/c++11.html +++ b/styleguide/c++/c++11.html @@ -478,6 +478,16 @@ and <a href="http://en.cppreference.com/w/cpp/container/unordered_set">std::unor <td>Per the <a href="https://google.github.io/styleguide/cppguide.html#std_hash">Google style guide</a>, specify custom hashers instead of specializing <code>std::hash</code> for custom types. <a href="https://groups.google.com/a/chromium.org/forum/#!topic/cxx/nCdjQqnouO4">Discussion thread</a>.</td> </tr> +<tr> +<td>Tuples</td> +<td><code>std::tuple</code></td> +<td>A fixed-size ordered collection of values of mixed types</td> +<td><a href="http://en.cppreference.com/w/cpp/utility/tuple">std::tuple</a></td> +<td><a href="https://crbug.com/554987">Tracking bug</a> to plan moving from <code>base::Tuple</code> to <code>std::tuple</code>. See also <code>std::tie</code>. +<code>base::Tuple</code> is now an alias for <code>std::tuple</code>. In class template specializations, use <code>std::tuple</code> instead of <code>base::Tuple</code> to work around a MSVS2013 internal compiler error (Error code: C1001). +</td> +</tr> + </tbody> </table> @@ -1026,14 +1036,6 @@ Declaring functions</a></td> </tr> <tr> -<td>Tuples</td> -<td><code>std::tuple</code></td> -<td>A fixed-size ordered collection of values of mixed types</td> -<td><a href="http://en.cppreference.com/w/cpp/utility/tuple">std::tuple</a></td> -<td><a href="https://crbug.com/554987">Tracking bug</a> to plan moving from <code>base::Tuple</code> to <code>std::tuple</code>. See also <code>std::tie</code></td> -</tr> - -<tr> <td>Type-Generic Math Functions</td> <td>Functions within <code><ctgmath></code></td> <td>Provides a means to call real or complex functions |