diff options
| author | stanisc <stanisc@chromium.org> | 2015-12-01 11:29:00 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-12-01 19:35:36 +0000 |
| commit | 29a902969435eeb9f162619ec4e57e78b7035616 (patch) | |
| tree | f323cf93a1a59195432c2f168378fe32651d5efc /sync/BUILD.gn | |
| parent | 4bb8a457d2f96b3f16ebdb94577737877e825e17 (diff) | |
| download | chromium_src-29a902969435eeb9f162619ec4e57e78b7035616.zip chromium_src-29a902969435eeb9f162619ec4e57e78b7035616.tar.gz chromium_src-29a902969435eeb9f162619ec4e57e78b7035616.tar.bz2 | |
ModelTypeEntity refactoring to use EntityData and EntityMetadata
1) Changed existing ModelTypeEntity to be based on
EntityMetadata, client key, and EntityDataPtr. Changed the
class construction functions slighly to better reuse the
code and to be able to pass the data without copying.
2) Moved model_type_entity* files next to shared_model_type_processor*
3) Did initial implementation of the data caching, although
it might still need some refinement. The code that prepares
commit request data structure now uses the cached EntityDataPtr.
4) Made necessary changes in SharedModelTypeProcessor to
ensure that all existing tests pass. Had to disable two
re-encryption tests because they expect the data received
in updates to be cached in ModelTypeEntity which isn't the
case anymore.
BUG=517657, 553638
Review URL: https://codereview.chromium.org/1471293005
Cr-Commit-Position: refs/heads/master@{#362475}
Diffstat (limited to 'sync/BUILD.gn')
| -rw-r--r-- | sync/BUILD.gn | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sync/BUILD.gn b/sync/BUILD.gn index d4d89d1..edeaf34dd 100644 --- a/sync/BUILD.gn +++ b/sync/BUILD.gn @@ -94,8 +94,6 @@ source_set("sync_core") { "engine/get_updates_delegate.h", "engine/get_updates_processor.cc", "engine/get_updates_processor.h", - "engine/model_type_entity.cc", - "engine/model_type_entity.h", "engine/model_type_worker.cc", "engine/model_type_worker.h", "engine/net/server_connection_manager.cc", @@ -173,6 +171,7 @@ source_set("sync_core") { "internal_api/js_sync_encryption_handler_observer.h", "internal_api/js_sync_manager_observer.cc", "internal_api/js_sync_manager_observer.h", + "internal_api/model_type_entity.cc", "internal_api/model_type_store_backend.cc", "internal_api/model_type_store_impl.cc", "internal_api/protocol_event_buffer.cc", @@ -243,6 +242,7 @@ source_set("sync_core") { "internal_api/public/http_post_provider_interface.h", "internal_api/public/internal_components_factory.h", "internal_api/public/internal_components_factory_impl.h", + "internal_api/public/model_type_entity.h", "internal_api/public/model_type_processor.cc", "internal_api/public/model_type_processor.h", "internal_api/public/model_type_store_backend.h", @@ -632,7 +632,6 @@ test("sync_unit_tests") { "engine/directory_update_handler_unittest.cc", "engine/entity_tracker_unittest.cc", "engine/get_updates_processor_unittest.cc", - "engine/model_type_entity_unittest.cc", "engine/model_type_worker_unittest.cc", "engine/sync_scheduler_unittest.cc", "engine/syncer_proto_util_unittest.cc", @@ -654,6 +653,7 @@ test("sync_unit_tests") { "internal_api/js_mutation_event_observer_unittest.cc", "internal_api/js_sync_encryption_handler_observer_unittest.cc", "internal_api/js_sync_manager_observer_unittest.cc", + "internal_api/model_type_entity_unittest.cc", "internal_api/model_type_store_backend_unittest.cc", "internal_api/model_type_store_impl_unittest.cc", "internal_api/protocol_event_buffer_unittest.cc", |