diff options
author | sgurun <sgurun@chromium.org> | 2015-05-19 13:24:46 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-05-19 20:24:52 +0000 |
commit | d98a8607394ca879f251a6be7e721a2b7a0b111c (patch) | |
tree | 2ad61136864a4a908e794de3450e5f524233f2d0 /sync/android/javatests | |
parent | 6cdb69279cb4f83fd8d1f31f58eb0edf44d2bec3 (diff) | |
download | chromium_src-d98a8607394ca879f251a6be7e721a2b7a0b111c.zip chromium_src-d98a8607394ca879f251a6be7e721a2b7a0b111c.tar.gz chromium_src-d98a8607394ca879f251a6be7e721a2b7a0b111c.tar.bz2 |
Revert of [Sync] Remove periodic sync for Chrome for Android (patchset #2 id:20001 of https://codereview.chromium.org/1148613002/)
Reason for revert:
seems to break the build
https://build.chromium.org/p/chromium/builders/Android/builds/40042
Original issue's description:
> [Sync] Remove periodic sync for Chrome for Android
>
> updateAccount() is always called on startup with the signed in account,
> so the removePeriodicSync() call will be hit even for already signed in
> users when the app restarts.
>
> BUG=480688
>
> Committed: https://crrev.com/20989a55f294c1b1643cbc2b80bf083de1dd7e36
> Cr-Commit-Position: refs/heads/master@{#330588}
TBR=nyquist@chromium.org,maxbogue@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=480688
Review URL: https://codereview.chromium.org/1135113006
Cr-Commit-Position: refs/heads/master@{#330592}
Diffstat (limited to 'sync/android/javatests')
-rw-r--r-- | sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java b/sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java index cb6fa9c..94e099b 100644 --- a/sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java +++ b/sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java @@ -6,7 +6,6 @@ package org.chromium.sync; import android.accounts.Account; import android.content.Context; -import android.os.Bundle; import android.test.InstrumentationTestCase; import android.test.suitebuilder.annotation.SmallTest; @@ -30,7 +29,6 @@ public class AndroidSyncSettingsTest extends InstrumentationTestCase { private int mGetIsSyncableCalls; private int mSetIsSyncableCalls; private int mSetSyncAutomaticallyCalls; - private int mRemovePeriodicSyncCalls; @Override public boolean getMasterSyncAutomatically() { @@ -61,12 +59,6 @@ public class AndroidSyncSettingsTest extends InstrumentationTestCase { mSetSyncAutomaticallyCalls++; super.setSyncAutomatically(account, authority, sync); } - - @Override - public void removePeriodicSync(Account account, String authority, Bundle extras) { - mRemovePeriodicSyncCalls++; - super.removePeriodicSync(account, authority, extras); - } } private static class MockSyncSettingsObserver implements AndroidSyncSettingsObserver { @@ -145,22 +137,6 @@ public class AndroidSyncSettingsTest extends InstrumentationTestCase { @SmallTest @Feature({"Sync"}) - public void testAccountInitialization() throws InterruptedException { - // mAccount was set to be syncable and not have periodic syncs. - assertEquals(1, mSyncContentResolverDelegate.mSetIsSyncableCalls); - assertEquals(1, mSyncContentResolverDelegate.mRemovePeriodicSyncCalls); - mAndroid.updateAccount(null); - // mAccount was set to be not syncable. - assertEquals(2, mSyncContentResolverDelegate.mSetIsSyncableCalls); - assertEquals(1, mSyncContentResolverDelegate.mRemovePeriodicSyncCalls); - mAndroid.updateAccount(mAlternateAccount); - // mAlternateAccount was set to be syncable and not have periodic syncs. - assertEquals(3, mSyncContentResolverDelegate.mSetIsSyncableCalls); - assertEquals(2, mSyncContentResolverDelegate.mRemovePeriodicSyncCalls); - } - - @SmallTest - @Feature({"Sync"}) public void testToggleMasterSyncFromSettings() throws InterruptedException { mSyncContentResolverDelegate.setMasterSyncAutomatically(true); mSyncContentResolverDelegate.waitForLastNotificationCompleted(); |