[Sync] Replacing SYNC_EXPORT_PRIVATE with SYNC_EXPORT for all usage, and fixing lint violations on all touched files.

Leaving the definition of the SYNC_EXPORT_PRIVATE macro because for some strange reason the iOS waterfall bot's incremental build doesn't re-generate the attachment's proto files. This causes a compile failure because the old versions of these generated files use the SYNC_EXPORT_MACRO. It has been difficult to reproduce this problem anywhere else, so it's unclear if something like a white-space change to the .proto definition would resolve this breakage.

BUG=554242, 567301

Review URL: https://codereview.chromium.org/1503343002

Cr-Commit-Position: refs/heads/master@{#364546}

1 files changed, 1 insertions, 1 deletions

diff --git a/sync/api/attachments/attachment_store.h b/sync/api/attachments/attachment_store.h
index 14fd0fc..5ddac1e 100644
--- a/sync/api/attachments/attachment_store.h
+++ b/sync/api/attachments/attachment_store.h
@@ -168,7 +168,7 @@ class SYNC_EXPORT AttachmentStore {
 // AttachmentService writes attachment on behalf of model type after download
 // and takes reference on attachment for the duration of upload.
 // Model type implementation shouldn't use this interface.
-class SYNC_EXPORT_PRIVATE AttachmentStoreForSync : public AttachmentStore {
+class SYNC_EXPORT AttachmentStoreForSync : public AttachmentStore {
  public:
   ~AttachmentStoreForSync();