diff options
| author | maniscalco@chromium.org <maniscalco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-17 06:47:44 +0000 |
|---|---|---|
| committer | maniscalco@chromium.org <maniscalco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-17 06:47:44 +0000 |
| commit | 8ac09b213e743837f51f441e51ddc5840f79cc6c (patch) | |
| tree | 2bfc36a80badf0d6b053b3f50fca62832396dd5f /sync/api | |
| parent | 35ea7cbc5e6e72ea9148a09f5f4643f1b9bf46d1 (diff) | |
| download | chromium_src-8ac09b213e743837f51f441e51ddc5840f79cc6c.zip chromium_src-8ac09b213e743837f51f441e51ddc5840f79cc6c.tar.gz chromium_src-8ac09b213e743837f51f441e51ddc5840f79cc6c.tar.bz2 | |
Do not update AttachmentIds after uploading attachments to sync server.
In a previous design iteration we planned to have the sync server assign
an attachments id after receiving an attachment upload. We have since
changed the design so the client is responsible for assigning the
attachment id before upload occurs.
Remove comments related to updating attachment id after upload.
Rename UpdateAttachmentIdWithServerInfo to MarkAttachmentAsOnServer.
Rename UpdateEntriesWithAttachmentId to
UpdateEntriesMarkAttachmentAsOnServer.
BUG=371522
Review URL: https://codereview.chromium.org/394293003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283670 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/api')
| -rw-r--r-- | sync/api/attachments/attachment_uploader.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sync/api/attachments/attachment_uploader.h b/sync/api/attachments/attachment_uploader.h index 12fe1a3..4774451 100644 --- a/sync/api/attachments/attachment_uploader.h +++ b/sync/api/attachments/attachment_uploader.h @@ -34,8 +34,8 @@ class SYNC_EXPORT AttachmentUploader { // |callback| will be invoked when the operation has completed (successfully // or otherwise). // - // |callback| will receive an UploadResult code and an updated AttachmentId - // containing the server address of the newly uploaded attachment. + // |callback| will receive an UploadResult code and the AttachmentId of the + // newly uploaded attachment. virtual void UploadAttachment(const Attachment& attachment, const UploadCallback& callback) = 0; }; |