diff options
| author | skym <skym@chromium.org> | 2015-12-10 16:27:53 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-12-11 00:28:35 +0000 |
| commit | 6344d79c2f94876e979d4760816090442c694845 (patch) | |
| tree | f9335bfe1593410b37ee62409de70ae6c24317ee /sync/base | |
| parent | 64e809d03a59d44e42960058371035866f8a1038 (diff) | |
| download | chromium_src-6344d79c2f94876e979d4760816090442c694845.zip chromium_src-6344d79c2f94876e979d4760816090442c694845.tar.gz chromium_src-6344d79c2f94876e979d4760816090442c694845.tar.bz2 | |
[Sync] Replacing SYNC_EXPORT_PRIVATE with SYNC_EXPORT for all usage, and fixing lint violations on all touched files.
Leaving the definition of the SYNC_EXPORT_PRIVATE macro because for some strange reason the iOS waterfall bot's incremental build doesn't re-generate the attachment's proto files. This causes a compile failure because the old versions of these generated files use the SYNC_EXPORT_MACRO. It has been difficult to reproduce this problem anywhere else, so it's unclear if something like a white-space change to the .proto definition would resolve this breakage.
BUG=554242, 567301
Review URL: https://codereview.chromium.org/1503343002
Cr-Commit-Position: refs/heads/master@{#364546}
Diffstat (limited to 'sync/base')
| -rw-r--r-- | sync/base/sync_export.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sync/base/sync_export.h b/sync/base/sync_export.h index 83c65a6..15f4134 100644 --- a/sync/base/sync_export.h +++ b/sync/base/sync_export.h @@ -8,6 +8,8 @@ #if defined(COMPONENT_BUILD) #if defined(WIN32) +// TODO(skym): Remove SYNC_EXPORT_PRIVATE, see crbug/554242. + #if defined(SYNC_IMPLEMENTATION) #define SYNC_EXPORT __declspec(dllexport) #define SYNC_EXPORT_PRIVATE __declspec(dllexport) |