diff options
author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-12 08:45:16 +0000 |
---|---|---|
committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-12 08:45:16 +0000 |
commit | c9daa4305bf8b1cc578ce8017518c474fa38afe9 (patch) | |
tree | 8c9851cee0c9d2244d3aee1b2ac42a3338e4c290 /sync/engine/syncer.h | |
parent | b9ec2e016bb556029d10c45a15a864948370f62d (diff) | |
download | chromium_src-c9daa4305bf8b1cc578ce8017518c474fa38afe9.zip chromium_src-c9daa4305bf8b1cc578ce8017518c474fa38afe9.tar.gz chromium_src-c9daa4305bf8b1cc578ce8017518c474fa38afe9.tar.bz2 |
This is the clean-up following r249138.
Introduce a GetUpdatesDelegate class to contain request behavior that is
specific to a GU type. There are implementations for Normal, Retry,
Poll and Configure GUs.
These implementations may have different members. For example, only the
'Normal' GU requires a NudgeTracker.
They also implement different functionality for building the request
message and for applying the received updates. The latter is to allow
the configure GetUpdates to apply updates directly on the sync thread.
The GU types can still vary in other ways that are not encapsulated in
the GU delegate. For example, the Poll GU is not retried on failure,
though this is not expressed in its GU delegate in any way.
BUG=278484
Review URL: https://codereview.chromium.org/137753010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250651 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/engine/syncer.h')
-rw-r--r-- | sync/engine/syncer.h | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/sync/engine/syncer.h b/sync/engine/syncer.h index 006ca3b..a1aeff8 100644 --- a/sync/engine/syncer.h +++ b/sync/engine/syncer.h @@ -71,13 +71,11 @@ class SYNC_EXPORT_PRIVATE Syncer { sessions::SyncSession* session); private: - void ApplyUpdates(sessions::SyncSession* session, - GetUpdatesProcessor* get_updates_processor); - bool DownloadUpdates( + bool DownloadAndApplyUpdates( ModelTypeSet request_types, sessions::SyncSession* session, GetUpdatesProcessor* get_updates_processor, - base::Callback<void(sync_pb::ClientToServerMessage*)> build_fn); + bool create_mobile_bookmarks_folder); // This function will commit batches of unsynced items to the server until the // number of unsynced and ready to commit items reaches zero or an error is |