diff options
| author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-12 18:15:45 +0000 |
|---|---|---|
| committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-12 18:15:45 +0000 |
| commit | 447a5b6333539c309e015ee8f98ff6d9e131fa85 (patch) | |
| tree | 4357764ce00fdfbff7809d348a16a5f601bd3b08 /sync/engine/verify_updates_command_unittest.cc | |
| parent | 13d5e1af907ece2266b391c322344fb0af43d9f0 (diff) | |
| download | chromium_src-447a5b6333539c309e015ee8f98ff6d9e131fa85.zip chromium_src-447a5b6333539c309e015ee8f98ff6d9e131fa85.tar.gz chromium_src-447a5b6333539c309e015ee8f98ff6d9e131fa85.tar.bz2 | |
Remove syncproto.h
Replace sync/engine/syncproto.h with sync/syncable/syncable_proto_util.h and
.cc. The tasks that used to be performed by member functions of the syncer::
proto wrapper classes are now handled by static member functions.
Unfortunately, serialization and de-serialization of syncable::Id to/from proto
fields has gotten a bit uglier. On the other hand, it's now much less magical
and mysterious.
The test intended to prevent regressions of crbug.com/134715 has been replaced
with a DCHECK. We'll have to rely on it to ensure that the protocol_version
field is always explicitly set.
BUG=136454
TEST=
Review URL: https://chromiumcodereview.appspot.com/10735041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146393 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/engine/verify_updates_command_unittest.cc')
| -rw-r--r-- | sync/engine/verify_updates_command_unittest.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sync/engine/verify_updates_command_unittest.cc b/sync/engine/verify_updates_command_unittest.cc index 8bf9ead..3375af8 100644 --- a/sync/engine/verify_updates_command_unittest.cc +++ b/sync/engine/verify_updates_command_unittest.cc @@ -52,7 +52,7 @@ class VerifyUpdatesCommandTest : public SyncerCommandTest { entry.Put(syncable::SERVER_SPECIFICS, default_specifics); } - void AddUpdate(GetUpdatesResponse* updates, + void AddUpdate(sync_pb::GetUpdatesResponse* updates, const std::string& id, const std::string& parent, const syncer::ModelType& type) { sync_pb::SyncEntity* e = updates->add_entries(); @@ -77,7 +77,8 @@ TEST_F(VerifyUpdatesCommandTest, AllVerified) { ExpectNoGroupsToChange(command_); - GetUpdatesResponse* updates = session()->mutable_status_controller()-> + sync_pb::GetUpdatesResponse* updates = + session()->mutable_status_controller()-> mutable_updates_response()->mutable_get_updates(); AddUpdate(updates, "b1", root, syncer::BOOKMARKS); AddUpdate(updates, "b2", root, syncer::BOOKMARKS); |