diff options
| author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-30 21:32:24 +0000 |
|---|---|---|
| committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-30 21:32:24 +0000 |
| commit | 3e2dbbc1fa2f7160ecb0b88e58f6c4422ac3ec67 (patch) | |
| tree | 7a91f035bd0cfbbda181aec85dcc6fb0a596ac03 /sync/internal_api/js_sync_manager_observer_unittest.cc | |
| parent | 6c14fefae02783edf15a7012a36d8c2d8af76759 (diff) | |
| download | chromium_src-3e2dbbc1fa2f7160ecb0b88e58f6c4422ac3ec67.zip chromium_src-3e2dbbc1fa2f7160ecb0b88e58f6c4422ac3ec67.tar.gz chromium_src-3e2dbbc1fa2f7160ecb0b88e58f6c4422ac3ec67.tar.bz2 | |
Track merged nudge sources
There's a lot of valuable information in coalesced nudges. Currently, one
nudge source can overwrite another, which leaves us in the dark as to why the
client behaved a certain way. In fact, today we can't even determine whether
or not any coalescing was done.
By logging all the coalesced sources and their payloads, we can learn a lot
more about client behaviour. I'm hoping to use this to improve our
notification effectiveness metrics.
BUG=138613
Review URL: https://chromiumcodereview.appspot.com/11416126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170549 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/internal_api/js_sync_manager_observer_unittest.cc')
| -rw-r--r-- | sync/internal_api/js_sync_manager_observer_unittest.cc | 30 |
1 files changed, 16 insertions, 14 deletions
diff --git a/sync/internal_api/js_sync_manager_observer_unittest.cc b/sync/internal_api/js_sync_manager_observer_unittest.cc index ee93336..3668400 100644 --- a/sync/internal_api/js_sync_manager_observer_unittest.cc +++ b/sync/internal_api/js_sync_manager_observer_unittest.cc @@ -75,20 +75,22 @@ TEST_F(JsSyncManagerObserverTest, OnInitializationComplete) { } TEST_F(JsSyncManagerObserverTest, OnSyncCycleCompleted) { - sessions::SyncSessionSnapshot snapshot(sessions::ModelNeutralState(), - false, - ModelTypeSet(), - ProgressMarkerMap(), - false, - 5, - 2, - 7, - sessions::SyncSourceInfo(), - false, - 0, - base::Time::Now(), - std::vector<int>(MODEL_TYPE_COUNT, 0), - std::vector<int>(MODEL_TYPE_COUNT, 0)); + sessions::SyncSessionSnapshot snapshot( + sessions::ModelNeutralState(), + false, + ModelTypeSet(), + ProgressMarkerMap(), + false, + 5, + 2, + 7, + sessions::SyncSourceInfo(), + std::vector<sessions::SyncSourceInfo>(), + false, + 0, + base::Time::Now(), + std::vector<int>(MODEL_TYPE_COUNT, 0), + std::vector<int>(MODEL_TYPE_COUNT, 0)); DictionaryValue expected_details; expected_details.Set("snapshot", snapshot.ToValue()); |