summaryrefslogtreecommitdiffstats
path: root/sync/internal_api/public/base
diff options
context:
space:
mode:
authorrsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-12-11 23:47:42 +0000
committerrsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-12-11 23:47:42 +0000
commitaa166d02133c942de7498ebab60a47de2827f3df (patch)
tree6d617d623d0a6b361ee4bf21728a5467a87ed613 /sync/internal_api/public/base
parentce507cbf2a4c50d83855f08f8717df736584338b (diff)
downloadchromium_src-aa166d02133c942de7498ebab60a47de2827f3df.zip
chromium_src-aa166d02133c942de7498ebab60a47de2827f3df.tar.gz
chromium_src-aa166d02133c942de7498ebab60a47de2827f3df.tar.bz2
[sync] Componentize sync: Part 2: Add SYNC_EXPORTs to files in src/sync/
One of the long term goals of the sync team is to pull sync code out of chrome.dll and into its own component. As of today, several chrome targets depend on various sync targets as defined in sync.gyp. We'd like to move to a world where all chrome targets outside sync.gyp simply depend on the target sync.gyp:sync, which is built into its own component. This patch sets the stage for full componentization by adding SYNC_EXPORT annotations to classes / methods within src/sync. The final step of breaking off sync into its own component will be done in https://codereview.chromium.org/11412211. BUG=136928 Review URL: https://chromiumcodereview.appspot.com/11515009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172458 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/internal_api/public/base')
-rw-r--r--sync/internal_api/public/base/invalidation.h5
-rw-r--r--sync/internal_api/public/base/model_type.h8
2 files changed, 7 insertions, 6 deletions
diff --git a/sync/internal_api/public/base/invalidation.h b/sync/internal_api/public/base/invalidation.h
index f25304b..18afcab 100644
--- a/sync/internal_api/public/base/invalidation.h
+++ b/sync/internal_api/public/base/invalidation.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -10,6 +10,7 @@
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
#include "base/time.h"
+#include "sync/base/sync_export.h"
namespace base {
class DictionaryValue;
@@ -19,7 +20,7 @@ namespace syncer {
// Opaque class that represents a local ack handle. We don't reuse the
// invalidation ack handles to avoid unnecessary dependencies.
-class AckHandle {
+class SYNC_EXPORT AckHandle {
public:
static AckHandle CreateUnique();
static AckHandle InvalidAckHandle();
diff --git a/sync/internal_api/public/base/model_type.h b/sync/internal_api/public/base/model_type.h
index 327d980..5b9b92d 100644
--- a/sync/internal_api/public/base/model_type.h
+++ b/sync/internal_api/public/base/model_type.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -137,7 +137,7 @@ bool ShouldMaintainPosition(ModelType model_type);
// These are the user-selectable data types. Note that some of these share a
// preference flag, so not all of them are individually user-selectable.
-ModelTypeSet UserTypes();
+SYNC_EXPORT ModelTypeSet UserTypes();
// This is the subset of UserTypes() that can be encrypted.
ModelTypeSet EncryptableUserTypes();
@@ -152,12 +152,12 @@ ModelTypeSet EncryptableUserTypes();
// - Their contents are not encrypted automatically.
// - They support custom update application and conflict resolution logic.
// - All change processing occurs on the sync thread (GROUP_PASSIVE).
-ModelTypeSet ControlTypes();
+SYNC_EXPORT ModelTypeSet ControlTypes();
// Returns true if this is a control type.
//
// See comment above for more information on what makes these types special.
-bool IsControlType(ModelType model_type);
+SYNC_EXPORT bool IsControlType(ModelType model_type);
// Determine a model type from the field number of its associated
// EntitySpecifics field. Returns UNSPECIFIED if the field number is