diff options
author | maniscalco <maniscalco@chromium.org> | 2014-11-17 17:52:26 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-11-18 01:52:51 +0000 |
commit | 41b0acac5f6ae101df41208dd721b0a7a647c17d (patch) | |
tree | 272d311e7d17e59fd913c3e685c1df7c1d79afe6 /sync/internal_api/public/read_transaction.h | |
parent | 0755060246e22371c9ac15c497b9278694e4a6e9 (diff) | |
download | chromium_src-41b0acac5f6ae101df41208dd721b0a7a647c17d.zip chromium_src-41b0acac5f6ae101df41208dd721b0a7a647c17d.tar.gz chromium_src-41b0acac5f6ae101df41208dd721b0a7a647c17d.tar.bz2 |
Send birthday on sync attachment uploads and downloads.
Refactor common URLFetcher settings into shared static method
(ConfigureURLFetcherCommon) called by both uploader and downloader.
Include User-Agent on uploads and downloads to aid in troubleshooting.
Use header constants from net::HttpRequestHeaders.
Make ReadTransaction's GetAttachmentIdsToUpload const.
BUG=371521, 433898
Review URL: https://codereview.chromium.org/729363005
Cr-Commit-Position: refs/heads/master@{#304541}
Diffstat (limited to 'sync/internal_api/public/read_transaction.h')
-rw-r--r-- | sync/internal_api/public/read_transaction.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/sync/internal_api/public/read_transaction.h b/sync/internal_api/public/read_transaction.h index 2084b9a..c75d16a 100644 --- a/sync/internal_api/public/read_transaction.h +++ b/sync/internal_api/public/read_transaction.h @@ -46,9 +46,12 @@ class SYNC_EXPORT ReadTransaction : public BaseTransaction { void GetDataTypeContext(ModelType type, sync_pb::DataTypeContext* context) const; - // Clears |id_set| and fills it with the ids of attachments that need to be + // Clear |id_set| and fill it with the ids of attachments that need to be // uploaded to the sync server. - void GetAttachmentIdsToUpload(ModelType type, AttachmentIdSet* id_set); + void GetAttachmentIdsToUpload(ModelType type, AttachmentIdSet* id_set) const; + + // Return the current (opaque) store birthday. + std::string GetStoreBirthday() const; private: void* operator new(size_t size); // Transaction is meant for stack use only. |