summaryrefslogtreecommitdiffstats
path: root/sync/internal_api/public/util
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2014-12-22 14:40:24 -0800
committerCommit bot <commit-bot@chromium.org>2014-12-22 22:41:02 +0000
commit520ae85e967f776f4134277cb14e487894421226 (patch)
tree509299de71fd5d8cba15fe5758a495fd86898524 /sync/internal_api/public/util
parentdf1702e8aa43e3996d64c0988e48612a5fad4624 (diff)
downloadchromium_src-520ae85e967f776f4134277cb14e487894421226.zip
chromium_src-520ae85e967f776f4134277cb14e487894421226.tar.gz
chromium_src-520ae85e967f776f4134277cb14e487894421226.tar.bz2
Standardize usage of virtual/override/final specifiers in sync/.
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 Review URL: https://codereview.chromium.org/792343004 Cr-Commit-Position: refs/heads/master@{#309474}
Diffstat (limited to 'sync/internal_api/public/util')
-rw-r--r--sync/internal_api/public/util/weak_handle_unittest.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/sync/internal_api/public/util/weak_handle_unittest.cc b/sync/internal_api/public/util/weak_handle_unittest.cc
index 7200329..4be4fb7 100644
--- a/sync/internal_api/public/util/weak_handle_unittest.cc
+++ b/sync/internal_api/public/util/weak_handle_unittest.cc
@@ -47,7 +47,7 @@ class Derived : public Base, public base::SupportsWeakPtr<Derived> {};
class WeakHandleTest : public ::testing::Test {
protected:
- virtual void TearDown() {
+ void TearDown() override {
// Process any last-minute posted tasks.
PumpLoop();
}