diff options
| author | maniscalco@chromium.org <maniscalco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-17 06:47:44 +0000 |
|---|---|---|
| committer | maniscalco@chromium.org <maniscalco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-17 06:47:44 +0000 |
| commit | 8ac09b213e743837f51f441e51ddc5840f79cc6c (patch) | |
| tree | 2bfc36a80badf0d6b053b3f50fca62832396dd5f /sync/internal_api/public/write_transaction.h | |
| parent | 35ea7cbc5e6e72ea9148a09f5f4643f1b9bf46d1 (diff) | |
| download | chromium_src-8ac09b213e743837f51f441e51ddc5840f79cc6c.zip chromium_src-8ac09b213e743837f51f441e51ddc5840f79cc6c.tar.gz chromium_src-8ac09b213e743837f51f441e51ddc5840f79cc6c.tar.bz2 | |
Do not update AttachmentIds after uploading attachments to sync server.
In a previous design iteration we planned to have the sync server assign
an attachments id after receiving an attachment upload. We have since
changed the design so the client is responsible for assigning the
attachment id before upload occurs.
Remove comments related to updating attachment id after upload.
Rename UpdateAttachmentIdWithServerInfo to MarkAttachmentAsOnServer.
Rename UpdateEntriesWithAttachmentId to
UpdateEntriesMarkAttachmentAsOnServer.
BUG=371522
Review URL: https://codereview.chromium.org/394293003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283670 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync/internal_api/public/write_transaction.h')
| -rw-r--r-- | sync/internal_api/public/write_transaction.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sync/internal_api/public/write_transaction.h b/sync/internal_api/public/write_transaction.h index 06d1354..2dbcdaa 100644 --- a/sync/internal_api/public/write_transaction.h +++ b/sync/internal_api/public/write_transaction.h @@ -52,9 +52,9 @@ class SYNC_EXPORT WriteTransaction : public BaseTransaction { syncer::SyncChangeProcessor::ContextRefreshStatus refresh_status, const std::string& context); - // Attachment id was just updated. Propagate this change to all entries that - // refer this attachment id and set is_on_server for corresponding records. - void UpdateEntriesWithAttachmentId(const AttachmentId& attachment_id); + // Update all entries that refer to |attachment_id| indicating that + // |attachment_id| has been uploaded to the sync server. + void UpdateEntriesMarkAttachmentAsOnServer(const AttachmentId& attachment_id); protected: WriteTransaction() {} |