diff options
| author | brettw <brettw@chromium.org> | 2015-04-08 12:48:22 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-08 19:48:56 +0000 |
| commit | 44a5cf89809a419225709657e86562137bb639b4 (patch) | |
| tree | 12503c490391b1c75d189b8cfb2e18511733f4df /sync/protocol | |
| parent | 9a1ebc79d74c9a85788735e99e28ec09788a4b34 (diff) | |
| download | chromium_src-44a5cf89809a419225709657e86562137bb639b4.zip chromium_src-44a5cf89809a419225709657e86562137bb639b4.tar.gz chromium_src-44a5cf89809a419225709657e86562137bb639b4.tar.bz2 | |
GN Windows component build fixes.
Fixes issues related to compiling chrome in component mode on Windows. This just does chrome, there are likely other issues for test targets. Getting Chrome to work will also require an ANGLE roll.
I converted two static_library -> source_set. These aren't necessary but I noticed the extra .libs were being created and these don't need real static libraries as far as I can tell.
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1069533002
Cr-Commit-Position: refs/heads/master@{#324274}
Diffstat (limited to 'sync/protocol')
| -rw-r--r-- | sync/protocol/BUILD.gn | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/sync/protocol/BUILD.gn b/sync/protocol/BUILD.gn index b8258f90..a8da5ac 100644 --- a/sync/protocol/BUILD.gn +++ b/sync/protocol/BUILD.gn @@ -4,7 +4,17 @@ import("//third_party/protobuf/proto_library.gni") -proto_library("protocol") { +# This must be a component for the dependency structure we have now, but the +# proto_library generates a source set. Link those into a component. +component("protocol") { + public_deps = [ + ":protocol_internal", + ] +} + +proto_library("protocol_internal") { + visibility = [ ":protocol" ] + sources = [ "app_list_specifics.proto", "app_notification_specifics.proto", |