diff options
| author | wittman <wittman@chromium.org> | 2015-03-17 14:14:46 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-03-17 21:15:39 +0000 |
| commit | c8ae1d65bada9e45e2fcfa4a00f0f18018e823bb (patch) | |
| tree | b77e450d0c7aed9a973ead75dd277fb673586c2a /sync/protocol | |
| parent | bba16e7a9323bca8d411ff5f51a94093d889df2b (diff) | |
| download | chromium_src-c8ae1d65bada9e45e2fcfa4a00f0f18018e823bb.zip chromium_src-c8ae1d65bada9e45e2fcfa4a00f0f18018e823bb.tar.gz chromium_src-c8ae1d65bada9e45e2fcfa4a00f0f18018e823bb.tar.bz2 | |
Remove enhanced bookmarks sync experiment
Uses the enhanced bookmarks Finch experiment as the only mechanism for
enabling enhanced bookmarks in Chrome. With this change we no longer
need the EnhancedBookmarks.SyncExperimentState UMA histogram since we
can now get all the relevant metrics via Finch.
BUG=467040
Review URL: https://codereview.chromium.org/1009673002
Cr-Commit-Position: refs/heads/master@{#320973}
Diffstat (limited to 'sync/protocol')
| -rw-r--r-- | sync/protocol/experiments_specifics.proto | 3 | ||||
| -rw-r--r-- | sync/protocol/proto_value_conversions.cc | 9 |
2 files changed, 2 insertions, 10 deletions
diff --git a/sync/protocol/experiments_specifics.proto b/sync/protocol/experiments_specifics.proto index 3006223..4fc0ada 100644 --- a/sync/protocol/experiments_specifics.proto +++ b/sync/protocol/experiments_specifics.proto @@ -70,7 +70,8 @@ message ExperimentsSpecifics { optional FaviconSyncFlags favicon_sync = 4; optional PreCommitUpdateAvoidanceFlags pre_commit_update_avoidance = 5; optional GcmChannelFlags gcm_channel = 6; - optional EnhancedBookmarksFlags enhanced_bookmarks = 7; + // No longer used as of M43. + optional EnhancedBookmarksFlags obsolete_enhanced_bookmarks = 7; optional GcmInvalidationsFlags gcm_invalidations = 8; optional WalletSyncFlags wallet_sync = 9; } diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc index 162062d..de55704 100644 --- a/sync/protocol/proto_value_conversions.cc +++ b/sync/protocol/proto_value_conversions.cc @@ -418,14 +418,6 @@ base::DictionaryValue* FaviconSyncFlagsToValue( return value; } -base::DictionaryValue* EnhancedBookmarksFlagsToValue( - const sync_pb::EnhancedBookmarksFlags& proto) { - base::DictionaryValue* value = new base::DictionaryValue(); - SET_BOOL(enabled); - SET_STR(extension_id); - return value; -} - } // namespace base::DictionaryValue* ExperimentsSpecificsToValue( @@ -437,7 +429,6 @@ base::DictionaryValue* ExperimentsSpecificsToValue( SET_EXPERIMENT_ENABLED_FIELD(pre_commit_update_avoidance); SET(favicon_sync, FaviconSyncFlagsToValue); SET_EXPERIMENT_ENABLED_FIELD(gcm_channel); - SET(enhanced_bookmarks, EnhancedBookmarksFlagsToValue); SET_EXPERIMENT_ENABLED_FIELD(gcm_invalidations); SET_EXPERIMENT_ENABLED_FIELD(wallet_sync); return value; |