diff options
| author | stanisc <stanisc@chromium.org> | 2015-09-28 12:28:42 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-09-28 19:30:57 +0000 |
| commit | a4e4a10e92844d0274895c1d078d9119fa76f041 (patch) | |
| tree | b91de6790c80c7c1587e54860fc47052d2bb15e9 /sync/sync.gyp | |
| parent | 516bee16e9437521cdd20a78d683f9dbaf35df3e (diff) | |
| download | chromium_src-a4e4a10e92844d0274895c1d078d9119fa76f041.zip chromium_src-a4e4a10e92844d0274895c1d078d9119fa76f041.tar.gz chromium_src-a4e4a10e92844d0274895c1d078d9119fa76f041.tar.bz2 | |
USS SyncContextProxy / data type activation refactoring
This refactoring prepares the code to introduction of
NonBlockingDataTypeController for USS datatypes. The goal
was to split the very large NonBlockingDataTypeController
change into a couple of smaller to make it easier to review
and verify.
The following changes are included here:
1) Introduced ActivationContext which is a structure that
contains all arguments needed to activate a USS datatype.
For now ActivationContext is passed via SyncContext /
SyncContextProxy, but the goal is to pass it directly
via BackendDataTypeConfigurer as an argument for
ActivateNonBlockingDataType.
ActivationContext is needed as a separate class because
NonBlockingDataTypeController will have to receive it
from the type processor's callback and temporarily hold
on to it.
2) BackendDataTypeConfigurer - two activation methods are
renamed to be directory specific and two more activation
methods for non-blocking data types are added.
3) DataTypeController cleanup - OnModelLoaded() virtual
method shouldn't be on the base class because it applies
only to some of the subclasses and is never invoked via the
base class.
BUG=515962
Review URL: https://codereview.chromium.org/1368683003
Cr-Commit-Position: refs/heads/master@{#351110}
Diffstat (limited to 'sync/sync.gyp')
| -rw-r--r-- | sync/sync.gyp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sync/sync.gyp b/sync/sync.gyp index 177c332..4bacdb0 100644 --- a/sync/sync.gyp +++ b/sync/sync.gyp @@ -174,6 +174,7 @@ 'engine/update_applicator.h', 'engine/update_handler.cc', 'engine/update_handler.h', + 'internal_api/activation_context.cc', 'internal_api/attachments/attachment_downloader.cc', 'internal_api/attachments/attachment_downloader_impl.cc', 'internal_api/attachments/attachment_service.cc', @@ -217,6 +218,7 @@ 'internal_api/js_sync_manager_observer.h', 'internal_api/protocol_event_buffer.cc', 'internal_api/protocol_event_buffer.h', + 'internal_api/public/activation_context.h', 'internal_api/public/attachments/attachment_downloader.h', 'internal_api/public/attachments/attachment_downloader_impl.h', 'internal_api/public/attachments/attachment_service.h', |