diff options
| author | Jeremy Roman <jbroman@chromium.org> | 2015-09-23 19:26:26 -0400 |
|---|---|---|
| committer | Jeremy Roman <jbroman@chromium.org> | 2015-09-23 23:28:49 +0000 |
| commit | 55c3216b15cec4ae024d16960f01ca7d3874dd55 (patch) | |
| tree | 257b2469e8f127efbd56cf4b0054d0f4d72ec059 /sync/syncable | |
| parent | b388c75b293fb4b0ae394ff75683416aa0a8c5ab (diff) | |
| download | chromium_src-55c3216b15cec4ae024d16960f01ca7d3874dd55.zip chromium_src-55c3216b15cec4ae024d16960f01ca7d3874dd55.tar.gz chromium_src-55c3216b15cec4ae024d16960f01ca7d3874dd55.tar.bz2 | |
Revert of [sql] Use memory-mapped I/O for sql::Connection. (patchset #8 id:140001 of https://codereview.chromium.org/1349863003/ )
Reason for revert:
mmap_enabled_ isn't initialized, causing MSAN failures:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_MSAN/5882/layout-test-results/virtual/sharedarraybuffer/fast/workers/constructor-proto-crash-log.txt
STDERR: ==3138==WARNING: MemorySanitizer: use-of-uninitialized-value
STDERR: #0 0x7fc8068d3a65 in ReleaseCacheMemoryIfNeeded sql/connection.cc:513:7
STDERR: #1 0x7fc8068d3a65 in sql::Connection::ExecuteAndReturnErrorCode(char const*) sql/connection.cc:943:0
STDERR: #2 0x7fc8068ca454 in sql::Connection::OpenInternal(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, sql::Connection::Retry) sql/connection.cc:1275:9
STDERR: #3 0x7fc8068c845f in sql::Connection::Open(base::FilePath const&) sql/connection.cc:367:10
STDERR: #4 0x7fc806b1b868 in storage::QuotaDatabase::LazyOpen(bool) storage/browser/quota/quota_database.cc:488:14
Original issue's description:
> [sql] Use memory-mapped I/O for sql::Connection.
>
> sql::Connection::Open*() uses PRAGMA mmap_size to enable SQLite's
> memory-mapped I/O. Additionally instrument to flush dirty pages from
> the page cache after writes.
>
> BUG=489784,533682
>
> Committed: https://crrev.com/9a1948a4d6d445d5c8e209bdcd1cd050af72060b
> Cr-Commit-Position: refs/heads/master@{#350362}
R=shess@chromium.org
TBR=pavely@chromium.org, pvalenzuela@chromium.org, rmcilroy@chromium.org, shess@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=489784,533682
Review URL: https://codereview.chromium.org/1365783002 .
Cr-Commit-Position: refs/heads/master@{#350386}
Diffstat (limited to 'sync/syncable')
| -rw-r--r-- | sync/syncable/directory_backing_store.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/sync/syncable/directory_backing_store.cc b/sync/syncable/directory_backing_store.cc index 3ba54e6..d49ede5 100644 --- a/sync/syncable/directory_backing_store.cc +++ b/sync/syncable/directory_backing_store.cc @@ -1690,10 +1690,6 @@ void DirectoryBackingStore::ResetAndCreateConnection() { db_->set_exclusive_locking(); db_->set_cache_size(32); db_->set_page_size(database_page_size_); - - // TODO(shess): Sync corruption tests interact poorly with mmap, disable for - // now. http://crbug.com/533682 - db_->set_mmap_disabled(); if (!catastrophic_error_handler_.is_null()) SetCatastrophicErrorHandler(catastrophic_error_handler_); } |