diff options
| author | hidehiko@chromium.org <hidehiko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-23 14:59:56 +0000 |
|---|---|---|
| committer | hidehiko@chromium.org <hidehiko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-23 14:59:56 +0000 |
| commit | cac33bb28be76b908b11e81fb10bf28af608ced8 (patch) | |
| tree | 41e4a5807e1732d39d49428fe24125a032cdf490 /sync | |
| parent | 6a62229511adabc4228c994f685dd2980b2feabf (diff) | |
| download | chromium_src-cac33bb28be76b908b11e81fb10bf28af608ced8.zip chromium_src-cac33bb28be76b908b11e81fb10bf28af608ced8.tar.gz chromium_src-cac33bb28be76b908b11e81fb10bf28af608ced8.tar.bz2 | |
Refactoring FileCopyManagerWrapper.onEvent related code.
This CL has couple small refactoring around FileCopyManagerWrapper.onEvent.
1) Introduce addListener/removeListener to FileCopyManager, and register
a listener in the constructor of FileCopyManagerWrapper. Instead, get rid of
getContentWindows for sendEvent_.
2) Refactor FileCopyManager.getInstance(). (Removes |root| argument, as it is
never passed nor used. Use FileCopyManager.instance_, instead of global
fileCopyManagerInstance.)
3) Remove FileCopyManagerWrapper.status_/getStatus(). Instead
running_/isRunning is introduced.
4) Along with 3), get rid of FileCopyManagerWrapper.getStatus() usage in
butter_bar.js.
5) Move FileCopyManagerWrapper.getCopyManagerAsync_ to the place closer to the
decorateAsyncMethod, which is the only caller of the method.
This is also the preparation of extracting event sending code in
FileCopyManager. The actual refactoring will be done in following CLs.
BUG=246976
TEST=Ran browser_test --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*" and tested manually.
Review URL: https://chromiumcodereview.appspot.com/19663010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213117 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'sync')
0 files changed, 0 insertions, 0 deletions