diff options
| author | pkasting <pkasting@chromium.org> | 2014-11-19 19:35:21 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-11-20 03:35:46 +0000 |
| commit | cba132919fff063c1cfbe88e9a6f1bf4583729cb (patch) | |
| tree | a5f503e05ed15b987b5d97aabeb66d9fa667a7a1 /sync | |
| parent | 85d89716b4de9d1280d74a9cbe70e9abcb9c274c (diff) | |
| download | chromium_src-cba132919fff063c1cfbe88e9a6f1bf4583729cb.zip chromium_src-cba132919fff063c1cfbe88e9a6f1bf4583729cb.tar.gz chromium_src-cba132919fff063c1cfbe88e9a6f1bf4583729cb.tar.bz2 | |
Use uint16 for port numbers more pervasively.
We currently use a mixture of ints and uint16s for port numbers. This triggers a variety of "value possibly truncated" warnings on MSVC (currently disabled) wherever we implicitly truncate. Fix this by using uint16 consistently through more functions. (Using int consistently would be more problematic as the majority of third-party/system APIs that use port numbers use 16-bit types for them.)
By far the majority of these changes are fallout from changing IPEndPoint, which is widely used; it'd be difficult to split this CL up into smaller pieces :(
Note that I didn't use uint16_t to avoid introducing inconsistencies between existing uint16 usage and new uint16_t usage. Conversion of everything to uint16_t can happen later.
This CL was reviewed and approved in pieces in the following CLs:
https://codereview.chromium.org/716223002/
https://codereview.chromium.org/717263003/
https://codereview.chromium.org/717373002/
https://codereview.chromium.org/718273002/
https://codereview.chromium.org/722503002/
Committing as TBR to the original reviewers.
BUG=81439
TEST=none
TBR=gunsch,cpu,jhawkins,davidben,jyasskin,mmenke
Review URL: https://codereview.chromium.org/655063002
Cr-Commit-Position: refs/heads/master@{#304961}
Diffstat (limited to 'sync')
| -rw-r--r-- | sync/internal_api/attachments/attachment_uploader_impl_unittest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sync/internal_api/attachments/attachment_uploader_impl_unittest.cc b/sync/internal_api/attachments/attachment_uploader_impl_unittest.cc index c113ac3..0a724b6 100644 --- a/sync/internal_api/attachments/attachment_uploader_impl_unittest.cc +++ b/sync/internal_api/attachments/attachment_uploader_impl_unittest.cc @@ -282,7 +282,7 @@ void AttachmentUploaderImplTest::SetUp() { base::Bind(&RequestHandler::HandleRequest, base::Unretained(request_handler_.get()))); - GURL url(base::StringPrintf("http://localhost:%d/", server_.port())); + GURL url(base::StringPrintf("http://localhost:%u/", server_.port())); token_service_.reset(new MockOAuth2TokenService); scoped_refptr<OAuth2TokenServiceRequest::TokenServiceProvider> |