A side-effect of this CL to summarise failing tests: https://codereview.chromium.org/1060613003/, was to lose information on output of failing tests. This CL restores that by recording the output of tests that thrown an exception during execution.

BUG=

Review URL: https://codereview.chromium.org/1096143004

Cr-Commit-Position: refs/heads/master@{#326028}

1 files changed, 3 insertions, 4 deletions

diff --git a/testing/chromoting/browser_tests_launcher.py b/testing/chromoting/browser_tests_launcher.py
index 053ea5e..2fceb7c 100644
--- a/testing/chromoting/browser_tests_launcher.py
+++ b/testing/chromoting/browser_tests_launcher.py
@@ -50,9 +50,8 @@ def RunCommandInSubProcess(command):
     results = subprocess.check_output(cmd_line, stderr=subprocess.STDOUT,
                                       shell=True)
   except subprocess.CalledProcessError, e:
-    raise Exception('Exception %s running command %s\n' %
-                    (e, command))
-  else:
+    results = e.output
+  finally:
     print results
   return results
 
@@ -196,7 +195,7 @@ def main(args):
   # Was there any test failure?
   if TEST_FAILURE:
     print '++++++++++AT LEAST 1 TEST FAILED++++++++++'
-    print FAILING_TESTS
+    print FAILING_TESTS.rstrip('\n')
     print '++++++++++++++++++++++++++++++++++++++++++'
     raise Exception('At least one test failed.')