diff options
| author | dpranke <dpranke@chromium.org> | 2015-09-18 12:07:00 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-09-18 19:07:49 +0000 |
| commit | b218d91ef159033438a8b79fc0ca8da7abdc2b8e (patch) | |
| tree | 45e814c3b88e0ad57c11ba1178fb46364164819c /testing | |
| parent | 31b2721a44330fb51fe59c2c6628e2a9593a384b (diff) | |
| download | chromium_src-b218d91ef159033438a8b79fc0ca8da7abdc2b8e.zip chromium_src-b218d91ef159033438a8b79fc0ca8da7abdc2b8e.tar.gz chromium_src-b218d91ef159033438a8b79fc0ca8da7abdc2b8e.tar.bz2 | |
Move `gn check` into the `generate_build_files` step.
The dedicated GN bots run a script test step called `gn_check`
that (unsurprisingly) runs `gn check` to validate that we
haven't introduced any bad build dependencies.
When we enabled GN on the regular Linux bots, we forgot to add
that step. It turns out that we can't easily add it, because
the Linux bots use a builder/tester split, and the script would
run on the tester, where we don't have a build directory and
don't know what GN args to check against.
This patch changes the MB/generate_build_files step to add the
--check flag to the normal `gn gen` invocation. This slows
down the generate_build_files step, but the time would be spent
somewhere anyway when we ran the gn check step, later.
This patch also removes the explicit gn_check test step from
all of the bots. This patch will have the side effect of starting
to run `gn check` on *every* GN configuration (GN check was only
being run on some of the configurations before).
R=jam@chromium.org, brettw@chromium.org
BUG=532230
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel
Review URL: https://codereview.chromium.org/1342293002
Cr-Commit-Position: refs/heads/master@{#349731}
Diffstat (limited to 'testing')
| -rw-r--r-- | testing/buildbot/chromium.linux.json | 10 | ||||
| -rw-r--r-- | testing/buildbot/client.v8.fyi.json | 7 | ||||
| -rw-r--r-- | testing/buildbot/tryserver.chromium.linux.json | 4 | ||||
| -rw-r--r-- | testing/buildbot/tryserver.v8.json | 7 |
4 files changed, 0 insertions, 28 deletions
diff --git a/testing/buildbot/chromium.linux.json b/testing/buildbot/chromium.linux.json index 3f7e0f2..8998571 100644 --- a/testing/buildbot/chromium.linux.json +++ b/testing/buildbot/chromium.linux.json @@ -68,12 +68,6 @@ { "test": "view_manager_unittests" } - ], - "scripts": [ - { - "name": "gn_check", - "script": "gn_check.py" - } ] }, "Android GN (dbg)": { @@ -578,10 +572,6 @@ ], "scripts": [ { - "name": "gn_check", - "script": "gn_check.py" - }, - { "args": [ "chrome" ], diff --git a/testing/buildbot/client.v8.fyi.json b/testing/buildbot/client.v8.fyi.json index bf05d07..95d77c7 100644 --- a/testing/buildbot/client.v8.fyi.json +++ b/testing/buildbot/client.v8.fyi.json @@ -58,13 +58,6 @@ "url_unittests", "views_unittests", "wm_unittests" - ], - "gtest_tests": [], - "scripts": [ - { - "name": "gn_check", - "script": "gn_check.py" - } ] } } diff --git a/testing/buildbot/tryserver.chromium.linux.json b/testing/buildbot/tryserver.chromium.linux.json index e04985c..ff9b807 100644 --- a/testing/buildbot/tryserver.chromium.linux.json +++ b/testing/buildbot/tryserver.chromium.linux.json @@ -347,10 +347,6 @@ ], "scripts": [ { - "name": "gn_check", - "script": "gn_check.py" - }, - { "args": [ "chrome" ], diff --git a/testing/buildbot/tryserver.v8.json b/testing/buildbot/tryserver.v8.json index f480a38..13d4632 100644 --- a/testing/buildbot/tryserver.v8.json +++ b/testing/buildbot/tryserver.v8.json @@ -59,13 +59,6 @@ "url_unittests", "views_unittests", "wm_unittests" - ], - "gtest_tests": [], - "scripts": [ - { - "name": "gn_check", - "script": "gn_check.py" - } ] } } |