diff options
author | fischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-15 21:30:08 +0000 |
---|---|---|
committer | fischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-15 21:30:08 +0000 |
commit | b8629c3292978dfbaf1391451f35cb1d1c7adea5 (patch) | |
tree | 4d1daa64f4fd1f78810ca24ef3143b2b9b8a5de7 /testing | |
parent | d551f73f1f007cd40074168d27f5d3de6ac3cc04 (diff) | |
download | chromium_src-b8629c3292978dfbaf1391451f35cb1d1c7adea5.zip chromium_src-b8629c3292978dfbaf1391451f35cb1d1c7adea5.tar.gz chromium_src-b8629c3292978dfbaf1391451f35cb1d1c7adea5.tar.bz2 |
Move ProvidePictureBuffers out of initialization and into the decode path.
This is required for various reasons:
- Clients don't necessarily know the dimensions of the video they feed to the
decoder. It's the decoder's job to figure it out from the encoded stream, but
it only gets a crack at that once Decode() is called, after initialization is
done.
- PPAPI plugins get to call PPB_* functions at will, which means that (to avoid
having to code re-entrancy into everything on the browser side) PPB_*
functions aren't allowed to call into PPP_* functions. So the previous call
sequence of Initialize->ProvidePictureBuffers->CreateTextures would deadlock
(requiring plugins to pre-create any textures they were going to get asked for
in the future).
Also a bit of minor cleanup & added TODOs for future cleanup, and changed
GetConfigs()' signature to match the PPAPI version of itself (return bool
instead of void).
BUG=none
TEST=OVDATest passes on kaen.
Review URL: http://codereview.chromium.org/7147006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89251 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'testing')
0 files changed, 0 insertions, 0 deletions