diff options
| author | msw <msw@chromium.org> | 2015-11-05 11:22:15 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-05 19:23:02 +0000 |
| commit | e3faad772792c9be1254bcc72aa4ce05ac810415 (patch) | |
| tree | 51f15a0072fb7eb39974e4ec2592128dd4e8ed36 /testing | |
| parent | 88eb991c4a087ba6de7594505438680778c10338 (diff) | |
| download | chromium_src-e3faad772792c9be1254bcc72aa4ce05ac810415.zip chromium_src-e3faad772792c9be1254bcc72aa4ce05ac810415.tar.gz chromium_src-e3faad772792c9be1254bcc72aa4ce05ac810415.tar.bz2 | |
Revert of Run Mojo apptests step on Windows main and cq bots. (patchset #2 id:20001 of https://codereview.chromium.org/1412563007/ )
Reason for revert:
The mojo_apptests step is failing flakily due to a high incidence rate of http://crbug.com/551083 (Flaky mojo BaseThreadInitThunk / RtlInitializeExceptionChain crashes on Windows)
Original issue's description:
> Run Mojo apptests step on Windows main and cq bots.
>
> Add mojo_apptests step to 'Win8 Aura' buildbot config for these bots:
> http://build.chromium.org/p/chromium.win/builders/Win8%20Aura
> http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng
>
> The step has run on FYI for months, with no flakes for 1 week:
> http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Windows
> (recent changes addressed blocking flakiness: http://crbug.com/517661)
>
> BUG=478244,517661
> TEST=New step passes on intended bots.
> R=dpranke@chromium.org
> TBR=phajdan.jr@chromium.org
>
> Committed: https://crrev.com/3e18cf082b743ba0209a38509f2b62f0c9b76638
> Cr-Commit-Position: refs/heads/master@{#357425}
TBR=phajdan.jr@chromium.org,dpranke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478244,517661
Review URL: https://codereview.chromium.org/1413773009
Cr-Commit-Position: refs/heads/master@{#358105}
Diffstat (limited to 'testing')
| -rw-r--r-- | testing/buildbot/chromium.win.json | 6 | ||||
| -rwxr-xr-x | testing/scripts/mojo_apptests.py | 2 |
2 files changed, 1 insertions, 7 deletions
diff --git a/testing/buildbot/chromium.win.json b/testing/buildbot/chromium.win.json index 40aa61d..4d8c735 100644 --- a/testing/buildbot/chromium.win.json +++ b/testing/buildbot/chromium.win.json @@ -1607,12 +1607,6 @@ { "test": "window_manager_unittests" } - ], - "scripts": [ - { - "name": "mojo_apptests", - "script": "mojo_apptests.py" - } ] }, "Win8 GN": { diff --git a/testing/scripts/mojo_apptests.py b/testing/scripts/mojo_apptests.py index 2672ad2..49b855da2 100755 --- a/testing/scripts/mojo_apptests.py +++ b/testing/scripts/mojo_apptests.py @@ -16,7 +16,7 @@ def main_run(args): build_dir = os.path.join(common.SRC_DIR, 'out', args.build_config_fs) with common.temporary_file() as tempfile_path: - rc = common.run_command([sys.executable, runner, build_dir, '--verbose', + rc = common.run_command([runner, build_dir, '--verbose', '--write-full-results-to', tempfile_path]) with open(tempfile_path) as f: results = json.load(f) |