diff options
| author | aelias@chromium.org <aelias@chromium.org> | 2015-08-27 20:39:02 +0000 |
|---|---|---|
| committer | aelias@chromium.org <aelias@chromium.org> | 2015-08-27 20:39:02 +0000 |
| commit | 249504f0721a0d2ddfe174f442155f7d27ca1c18 (patch) | |
| tree | 02993bdda1e64d403dc2a2b6feb985cb6802a922 /third_party/WebKit/LayoutTests/compositing | |
| parent | e69db09865fa95ee6ed0c26bfdb6f9560b401b8e (diff) | |
| download | chromium_src-249504f0721a0d2ddfe174f442155f7d27ca1c18.zip chromium_src-249504f0721a0d2ddfe174f442155f7d27ca1c18.tar.gz chromium_src-249504f0721a0d2ddfe174f442155f7d27ca1c18.tar.bz2 | |
Reland of place pinch scrollbars with regular scrollbars. (patchset #1 id:1 of https://codereview.chromium.org/1318603005/ )
Reason for revert:
After discussion with samuong@, the original patch should be OK to reland as is and https://codereview.chromium.org/1317153002 is an appropriate fix for the crasher.
Original issue's description:
> Revert of Replace pinch scrollbars with regular scrollbars. (patchset #10 id:180001 of https://codereview.chromium.org/1308053003/ )
>
> Reason for revert:
> Introduced ChromeDriver devtools mobile emulation crash https://code.google.com/p/chromedriver/issues/detail?id=1205
>
> Original issue's description:
> > Replace pinch scrollbars with regular scrollbars.
> >
> > This patch makes the visual-viewport-managed scrollbars exclusive to
> > Android and improves normal scrollbars to be usable during pinch as follows:
> >
> > 1. Attach the scrollbar layers to the visual viewport, so they're always
> > onscreen as you zoom in (as already shipped on Mac).
> > 2. Set the container layer to the inner clip layer, so that the size and
> > position of the thumb reflects the sum of the two viewports,
> > instead of just the layout viewport.
> >
> > Note that result of these changes is visually indistiguishable at
> > minimum page scale. It only improves the behavior when zoomed in.
> >
> > BUG=523056
> >
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201285
>
> TBR=rbyers@chromium.org,skobes@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=523056
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201333
TBR=rbyers@chromium.org,skobes@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=523056
Review URL: https://codereview.chromium.org/1305223004
git-svn-id: svn://svn.chromium.org/blink/trunk@201337 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Diffstat (limited to 'third_party/WebKit/LayoutTests/compositing')
10 files changed, 42 insertions, 1 deletions
diff --git a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-down.html b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-down.html index 459437a..7c67b7a 100644 --- a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-down.html +++ b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-composited-page-scale-down.html @@ -2,6 +2,10 @@ <html> <head> <style> +::-webkit-scrollbar { + width: 0px; + height: 0px; +} .fixed-no-z-index { position: absolute; left: 10px; diff --git a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-composited-page-scale.html b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-composited-page-scale.html index b96cd88..8a34961 100644 --- a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-composited-page-scale.html +++ b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-composited-page-scale.html @@ -2,6 +2,10 @@ <html> <head> <style> +::-webkit-scrollbar { + width: 0px; + height: 0px; +} .fixed-no-z-index { position: absolute; left: 10px; diff --git a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale-down.html b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale-down.html index 8c8841a..b9d4962 100644 --- a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale-down.html +++ b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale-down.html @@ -2,6 +2,10 @@ <html> <head> <style> +::-webkit-scrollbar { + width: 0px; + height: 0px; +} .fixed-no-z-index { position: absolute; left: 10px; diff --git a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale.html b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale.html index e67d90f..85b48e0 100644 --- a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale.html +++ b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-iframe-composited-page-scale.html @@ -2,6 +2,10 @@ <html> <head> <style> +::-webkit-scrollbar { + width: 0px; + height: 0px; +} .fixed-no-z-index { position: absolute; left: 10px; diff --git a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale-down.html b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale-down.html index f949c92..38b9f909 100644 --- a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale-down.html +++ b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale-down.html @@ -2,6 +2,10 @@ <html> <head> <style> +::-webkit-scrollbar { + width: 0px; + height: 0px; +} .fixed-no-z-index { position: absolute; left: 10px; diff --git a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale.html b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale.html index 4d7f1cb..5e6f656 100644 --- a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale.html +++ b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position-transform-composited-page-scale.html @@ -2,6 +2,10 @@ <html> <head> <style> +::-webkit-scrollbar { + width: 0px; + height: 0px; +} .fixed-no-z-index { position: absolute; left: 10px; diff --git a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position.html b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position.html index 986ec08..60a86e4 100644 --- a/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position.html +++ b/third_party/WebKit/LayoutTests/compositing/geometry/fixed-position.html @@ -7,6 +7,10 @@ <title>Position fixed</title> <script src="../resources/mock_scrollbars.js"></script> <style type="text/css" media="screen"> + ::-webkit-scrollbar { + width: 0px; + height: 0px; + } body { height: 1000px; width: 1000px; diff --git a/third_party/WebKit/LayoutTests/compositing/geometry/vertical-scroll-composited.html b/third_party/WebKit/LayoutTests/compositing/geometry/vertical-scroll-composited.html index 3b016d9..ee1ff72 100644 --- a/third_party/WebKit/LayoutTests/compositing/geometry/vertical-scroll-composited.html +++ b/third_party/WebKit/LayoutTests/compositing/geometry/vertical-scroll-composited.html @@ -5,7 +5,12 @@ if (window.testRunner) testRunner.waitUntilDone(); </script> - <script src="../resources/mock_scrollbars.js"></script> + <style> + ::-webkit-scrollbar { + width: 0px; + height: 0px; + } + </style> </head> <body style="height: 600px"> <div style="transform: rotate3d(0,0,1,20deg); width: 800px; height: 1000px; border-style: solid; border-color: Red; border-width: 3px; background-image: url(../resources/apple.jpg); background-repeat:repeat"></div> diff --git a/third_party/WebKit/LayoutTests/compositing/overflow/fixed-position-ancestor-clip.html b/third_party/WebKit/LayoutTests/compositing/overflow/fixed-position-ancestor-clip.html index d6516e1..69cbb35 100644 --- a/third_party/WebKit/LayoutTests/compositing/overflow/fixed-position-ancestor-clip.html +++ b/third_party/WebKit/LayoutTests/compositing/overflow/fixed-position-ancestor-clip.html @@ -4,6 +4,10 @@ <head> <title>Position fixed with transform</title> <style type="text/css" media="screen"> + ::-webkit-scrollbar { + width: 0px; + height: 0px; + } body { height: 1000px; width: 1000px; diff --git a/third_party/WebKit/LayoutTests/compositing/scaling/tiled-layer-recursion.html b/third_party/WebKit/LayoutTests/compositing/scaling/tiled-layer-recursion.html index 1a4977c..18f81d1 100644 --- a/third_party/WebKit/LayoutTests/compositing/scaling/tiled-layer-recursion.html +++ b/third_party/WebKit/LayoutTests/compositing/scaling/tiled-layer-recursion.html @@ -3,6 +3,10 @@ <html> <head> <style> + ::-webkit-scrollbar { + width: 0px; + height: 0px; + } .composited { background-color: green; width: 200px; |