diff options
| author | dpranke@chromium.org <dpranke@chromium.org> | 2015-06-05 21:07:48 +0000 |
|---|---|---|
| committer | dpranke@chromium.org <dpranke@chromium.org> | 2015-06-05 21:07:48 +0000 |
| commit | 74dcdee0facef13e0a8b66f1f8efee1c4d280e9a (patch) | |
| tree | 3abb220580125ba54969e4311c306c533fce24bc /third_party/WebKit/LayoutTests/editing/deleting/delete-empty-table-expected.txt | |
| parent | e24b736789a78a358b7d11edde26255b87821f51 (diff) | |
| download | chromium_src-74dcdee0facef13e0a8b66f1f8efee1c4d280e9a.zip chromium_src-74dcdee0facef13e0a8b66f1f8efee1c4d280e9a.tar.gz chromium_src-74dcdee0facef13e0a8b66f1f8efee1c4d280e9a.tar.bz2 | |
Try Yet Again to handle the output we get from android in run-webkit-tests.
We're seeing more crashes logging debug output (adb logcat) on the bots.
We had been assuming that the stdout and stderr from the subprocess
were regular binary pipes, but it turns out the android port (and only
the android port) was actually setting universal_newlines=True when
launching the subprocess (this is apparently needed because 'adb shell'
does implicit linefeed conversion).
This has the nasty side effect of making the file objects unicode instead of
bytestrs, which was causing us to crash down the road when we tried to
.decode('ascii') a unicode string (.decode() only works on bytes).
This patch fixes the bug and adds some more assertions and comments.
R=peter@chromium.org, wangxianzhu@chromium.org, joelo@chromium.org
BUG=386343, 496983
Review URL: https://codereview.chromium.org/1169433005
git-svn-id: svn://svn.chromium.org/blink/trunk@196605 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Diffstat (limited to 'third_party/WebKit/LayoutTests/editing/deleting/delete-empty-table-expected.txt')
0 files changed, 0 insertions, 0 deletions