diff options
| author | dglazkov@chromium.org <dglazkov@chromium.org@bbb929c8-8fbe-4397-9dbb-9b2b20218538> | 2009-03-12 19:34:02 +0000 |
|---|---|---|
| committer | dglazkov@chromium.org <dglazkov@chromium.org@bbb929c8-8fbe-4397-9dbb-9b2b20218538> | 2009-03-12 19:34:02 +0000 |
| commit | 58aa626fc71db47e3530299b9a1f4539d8615b10 (patch) | |
| tree | 211a0582b4ed3347d0f158f274e9407ca7301123 /third_party/WebKit/LayoutTests/fast/js/console-non-string-values.html | |
| parent | b1eb783ad1d917c5956fa6cad55077c5fac10b52 (diff) | |
| download | chromium_src-58aa626fc71db47e3530299b9a1f4539d8615b10.zip chromium_src-58aa626fc71db47e3530299b9a1f4539d8615b10.tar.gz chromium_src-58aa626fc71db47e3530299b9a1f4539d8615b10.tar.bz2 | |
WebCore:
2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=24496
Fix console logging of non-string values by coercing the argument to
a string.
Test: fast/js/console-non-string-values.html
* bindings/js/ScriptValue.cpp: Removed PlatformString include.
* bindings/js/ScriptValue.h: Added toString method.
(WebCore::ScriptValue::toString):
* page/Console.cpp:
(WebCore::getFirstArgumentAsString): Changed firstArgumentAsString method to use
ScriptValue::toString.
(WebCore::Console::addMessage): added extra ScriptState argument to callsite.
(WebCore::Console::count): Ditto.
LayoutTests:
2009-03-12 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=24496
Test for logging non-string values.
* fast/js/console-non-string-values-expected.txt: Added.
* fast/js/console-non-string-values.html: Added.
git-svn-id: svn://svn.chromium.org/blink/trunk@41640 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Diffstat (limited to 'third_party/WebKit/LayoutTests/fast/js/console-non-string-values.html')
| -rw-r--r-- | third_party/WebKit/LayoutTests/fast/js/console-non-string-values.html | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/third_party/WebKit/LayoutTests/fast/js/console-non-string-values.html b/third_party/WebKit/LayoutTests/fast/js/console-non-string-values.html new file mode 100644 index 0000000..b11861f --- /dev/null +++ b/third_party/WebKit/LayoutTests/fast/js/console-non-string-values.html @@ -0,0 +1,18 @@ +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> +<html> +<head> +<link rel="stylesheet" href="resources/js-test-style.css"> +<script src="resources/js-test-pre.js"></script> +</head> +<body> +<p id="description"></p> +<div id="console"></div> +<script> +debug('Should see two console messages, the first a string, and the second a number.'); +window.console.log('I am a string'); +window.console.log(42); +var successfullyParsed = true; +</script> +<script src="resources/js-test-post.js"></script> +</body> +</html> |