diff options
author | eric@webkit.org <eric@webkit.org@bbb929c8-8fbe-4397-9dbb-9b2b20218538> | 2010-05-08 06:10:59 +0000 |
---|---|---|
committer | eric@webkit.org <eric@webkit.org@bbb929c8-8fbe-4397-9dbb-9b2b20218538> | 2010-05-08 06:10:59 +0000 |
commit | ff3db5cd1a6f9ab9985bdcd751a1c68daf8a6128 (patch) | |
tree | d29e2e5a71b0f5c40fcf8f9272f469bc0c99ea48 /third_party/WebKit/LayoutTests/fast/js/script-tests/global-resolve-through-eval.js | |
parent | ccce8b1e90cc8cb7ee66aec05a90a987549d47c6 (diff) | |
download | chromium_src-ff3db5cd1a6f9ab9985bdcd751a1c68daf8a6128.zip chromium_src-ff3db5cd1a6f9ab9985bdcd751a1c68daf8a6128.tar.gz chromium_src-ff3db5cd1a6f9ab9985bdcd751a1c68daf8a6128.tar.bz2 |
2010-05-06 Eric Seidel <eric@webkit.org>
Reviewed by Daniel Bates.
test-webkitpy fails under cygwin
https://bugs.webkit.org/show_bug.cgi?id=38718
* Scripts/webkitpy/common/system/executive.py:
- Add _KILL_PROCESS_KILLED_PROCESS_EXIT_CODE and
_KILL_ALL_KILLED_PROCESS_EXIT_CODE to store the expected
exit codes of processes killed by kill_process and kill_all.
These two constants are only used by the unit tests but are
stored in executive.py so they can be right next to the platform ifs.
- Remove unnecessary str() conversion, run_command does that for us.
- Make os.kill retry on cygwin on EAGAIN. It's unclear why CYGWIN
throws EAGAIN, but it only does so sometimes. 3 may not be enough
retries, but we'll try it to start with.
- Add _windows_image_name to automatically convert "yes" to "yes.exe"
for use with taskkill.exe /im. Various callers to kill_all could
be updated to remove the .exe, but that can be done in another patch.
- Use taskkill.exe for killall on cygwin.
* Scripts/webkitpy/common/system/executive_unittest.py:
- Use the new *_KILLED_PROCESS_EXIT_CODE constants which are correctly
set to 0 on windows/cygwin systems where taskkill.exe is used.
- Test _windows_image_name
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Add FIXME about including mac-snowleopard in baseline_search_path.
* Scripts/webkitpy/layout_tests/port/webkit.py:
- Make default_configuration actually read from the Configuration file.
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
- Test default_configuration
* Scripts/webkitpy/layout_tests/port/win.py:
- Need a basic baseline_search_path if --platform dryrun is to work.
git-svn-id: svn://svn.chromium.org/blink/trunk@59000 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Diffstat (limited to 'third_party/WebKit/LayoutTests/fast/js/script-tests/global-resolve-through-eval.js')
-rw-r--r-- | third_party/WebKit/LayoutTests/fast/js/script-tests/global-resolve-through-eval.js | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/third_party/WebKit/LayoutTests/fast/js/script-tests/global-resolve-through-eval.js b/third_party/WebKit/LayoutTests/fast/js/script-tests/global-resolve-through-eval.js deleted file mode 100644 index f8a2cf1..0000000 --- a/third_party/WebKit/LayoutTests/fast/js/script-tests/global-resolve-through-eval.js +++ /dev/null @@ -1,12 +0,0 @@ -description("Make sure we do a correct property resolution of a global object property when contained by eval."); - -var pass = false; - -var accessGlobal = (function() { return eval("var pass=true; (function(){ return pass; })"); })(); -var accessLocal = (function() { var pass = false; return (function() { return eval("var pass=true; (function(){ return pass; })"); })(); })(); - -shouldBeTrue("accessGlobal()"); -shouldBeTrue("accessLocal()"); - - -var successfullyParsed = true; |