diff options
author | yutak <yutak@chromium.org> | 2015-10-28 21:52:30 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-10-29 04:53:25 +0000 |
commit | 09ef60c77cd3cc9e5d230196fa834a99ba98f5d4 (patch) | |
tree | 3b0c6487151a1bee5dde9c7cac581a7111e35fc9 /third_party/WebKit/Source/config.gni | |
parent | 134a98262f8cdb59c43fef8ee85a68c7ed86bdc2 (diff) | |
download | chromium_src-09ef60c77cd3cc9e5d230196fa834a99ba98f5d4.zip chromium_src-09ef60c77cd3cc9e5d230196fa834a99ba98f5d4.tar.gz chromium_src-09ef60c77cd3cc9e5d230196fa834a99ba98f5d4.tar.bz2 |
GN: Enable blink_gc_plugin in GN builds.
The code added in this change is mostly similar to what
find_bad_constructs does in //build/config/clang/BUILD.gn.
blink_gc_plugin was false originally but changed to true, because the
corresponding variable in GYP builds is true by default. Also this patch
removes a variable blink_gc_plugin_dump_graph, as it is not used to the
best of my knowledge.
BUG=547135
R=brettw@chromium.org, oilpan-reviews@chromium.org
Review URL: https://codereview.chromium.org/1406993006
Cr-Commit-Position: refs/heads/master@{#356766}
Diffstat (limited to 'third_party/WebKit/Source/config.gni')
-rw-r--r-- | third_party/WebKit/Source/config.gni | 25 |
1 files changed, 11 insertions, 14 deletions
diff --git a/third_party/WebKit/Source/config.gni b/third_party/WebKit/Source/config.gni index 596b6c4..21a66d8 100644 --- a/third_party/WebKit/Source/config.gni +++ b/third_party/WebKit/Source/config.gni @@ -18,8 +18,7 @@ if (current_cpu == "arm") { declare_args() { # Set to true to enable the clang plugin that checks the usage of the Blink # garbage-collection infrastructure during compilation. - blink_gc_plugin = false - blink_gc_plugin_dump_graph = false + blink_gc_plugin = true blink_asserts_always_on = false } @@ -29,11 +28,10 @@ declare_args() { # will also enable WebAudio support on Android ARM, ia32 and x64. Default is # enabled. Whether WebAudio is actually available depends on runtime settings # and flags. -use_openmax_dl_fft = is_android && - (current_cpu == "x86" || - current_cpu == "x64" || - (current_cpu == "arm" && arm_version >= 7) || - current_cpu == "mipsel") +use_openmax_dl_fft = + is_android && + (current_cpu == "x86" || current_cpu == "x64" || + (current_cpu == "arm" && arm_version >= 7) || current_cpu == "mipsel") use_webaudio_ffmpeg = !is_mac && !is_android @@ -44,9 +42,7 @@ use_concatenated_impulse_responses = true # feature_defines_list --------------------------------------------------------- -feature_defines_list = [ - "ENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0", -] +feature_defines_list = [ "ENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0" ] if (is_debug) { # TODO(GYP) this should also be set when release_valgrind_build is set, @@ -72,6 +68,7 @@ if (use_webaudio_ffmpeg) { if (use_openmax_dl_fft) { feature_defines_list += [ "WTF_USE_WEBAUDIO_OPENMAX_DL_FFT=1", + # Enabling the FFT is enough to enable WebAudio support to # allow most WebAudio features to work on Android. "ENABLE_WEB_AUDIO=1", @@ -92,7 +89,7 @@ if (blink_asserts_always_on) { # Convert the list to a space-separated string for passing to scripts. # This would be the equivalent of passing '<(feature_defines)' in GYP. -feature_defines_string = exec_script( - "build/gn_list_to_space_separated_string.py", - feature_defines_list, - "trim string") +feature_defines_string = + exec_script("build/gn_list_to_space_separated_string.py", + feature_defines_list, + "trim string") |