diff options
| author | mikhail.pozdnyakov@intel.com <mikhail.pozdnyakov@intel.com@bbb929c8-8fbe-4397-9dbb-9b2b20218538> | 2014-04-03 07:57:02 +0000 |
|---|---|---|
| committer | mikhail.pozdnyakov@intel.com <mikhail.pozdnyakov@intel.com@bbb929c8-8fbe-4397-9dbb-9b2b20218538> | 2014-04-03 07:57:02 +0000 |
| commit | 5d5eacee9ce23835f9ad80a00299e0127fd20dd8 (patch) | |
| tree | 0815f59af259cdda07c38f6f12d11a5ad0b8a80d /third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp | |
| parent | b8d1870310756f8f3325c9e256c96a0d1e52e6cc (diff) | |
| download | chromium_src-5d5eacee9ce23835f9ad80a00299e0127fd20dd8.zip chromium_src-5d5eacee9ce23835f9ad80a00299e0127fd20dd8.tar.gz chromium_src-5d5eacee9ce23835f9ad80a00299e0127fd20dd8.tar.bz2 | |
HashMap misuse in ImageResourceTest.CancelOnDetach unit test
The ImageResourceTest.CancelOnDetach test should not leave its
ImageResource's identifier uninitialized (empty) as this identifier
is used as a key value in the 'ProgressTracker::m_progressItems'
HashMap (passing empty keys to WTF::HashMap leads to undefined
behavior and is not allowed).
Review URL: https://codereview.chromium.org/221933004
git-svn-id: svn://svn.chromium.org/blink/trunk@170749 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Diffstat (limited to 'third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp')
| -rw-r--r-- | third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp index 4c723e2..0ec0b39 100644 --- a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp +++ b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp @@ -37,6 +37,7 @@ #include "core/fetch/ResourceFetcher.h" #include "core/fetch/ResourcePtr.h" #include "core/loader/DocumentLoader.h" +#include "core/loader/UniqueIdentifier.h" #include "core/testing/DummyPageHolder.h" #include "core/testing/UnitTestHelpers.h" #include "platform/SharedBuffer.h" @@ -109,6 +110,8 @@ TEST(ImageResourceTest, CancelOnDetach) // Emulate starting a real load. ResourcePtr<ImageResource> cachedImage = new ImageResource(ResourceRequest(testURL)); + cachedImage->setIdentifier(createUniqueIdentifier()); + cachedImage->load(documentLoader->fetcher(), ResourceLoaderOptions()); memoryCache()->add(cachedImage.get()); |