diff options
| author | haraken@chromium.org <haraken@chromium.org@bbb929c8-8fbe-4397-9dbb-9b2b20218538> | 2014-08-07 03:46:46 +0000 |
|---|---|---|
| committer | haraken@chromium.org <haraken@chromium.org@bbb929c8-8fbe-4397-9dbb-9b2b20218538> | 2014-08-07 03:46:46 +0000 |
| commit | 171ae7cfeb697c9e0dd09838b0eecdd812a0289f (patch) | |
| tree | 093304fc3cfb0638127c041e1826bfc4fa003294 /third_party/WebKit/Source/modules/webaudio/DelayProcessor.cpp | |
| parent | b2cc4106e9ccb96b6c26b6c0fd55cb274482c081 (diff) | |
| download | chromium_src-171ae7cfeb697c9e0dd09838b0eecdd812a0289f.zip chromium_src-171ae7cfeb697c9e0dd09838b0eecdd812a0289f.tar.gz chromium_src-171ae7cfeb697c9e0dd09838b0eecdd812a0289f.tar.bz2 | |
Revert 179609 "Oilpan: Move AudioDSPKernel's hierarchy to oilpan..."
This broke webaudio tests in oilpan builds.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=http/tests/serviceworker/fetch-event.html,webaudio/biquad-allpass.html,webaudio/biquad-bandpass.html,webaudio/biquad-highpass.html,webaudio/biquad-highshelf.html,webaudio/biquad-lowpass.html,webaudio/biquad-lowshelf.html,webaudio/biquad-notch.html,webaudio/biquad-peaking.html,webaudio/delaynode-max-default-delay.html,webaudio/delaynode-max-nondefault-delay.html,webaudio/delaynode-maxdelay.html,webaudio/delaynode-maxdelaylimit.html,webaudio/delaynode-scheduling.html,webaudio/delaynode.html,webaudio/panner-loop.html
This is because AudioDSPKernel objects are allocated by audio threads
which are not regsistered to oilpan. This means that we can move AudioDSPKernel
to oilpan's heap.
> Oilpan: Move AudioDSPKernel's hierarchy to oilpan's heap
>
> This is a preparation for enabling oilpan by default for webaudio/.
>
> This CL changes HRTFPanner::m_delayLineL and HRTFPanner::m_delayLineR
> from part-of-objects to heap-allocated objects. This is because AudioDSPKernel
> is used as on-heap objects in other places (we don't want to mix part-of-objects
> and heap-allocated objects).
>
> BUG=340522
>
> Review URL: https://codereview.chromium.org/445593002
TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/444343002
git-svn-id: svn://svn.chromium.org/blink/trunk@179679 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Diffstat (limited to 'third_party/WebKit/Source/modules/webaudio/DelayProcessor.cpp')
| -rw-r--r-- | third_party/WebKit/Source/modules/webaudio/DelayProcessor.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/third_party/WebKit/Source/modules/webaudio/DelayProcessor.cpp b/third_party/WebKit/Source/modules/webaudio/DelayProcessor.cpp index 6fc6f6a..ad4d29d 100644 --- a/third_party/WebKit/Source/modules/webaudio/DelayProcessor.cpp +++ b/third_party/WebKit/Source/modules/webaudio/DelayProcessor.cpp @@ -51,9 +51,9 @@ void DelayProcessor::trace(Visitor* visitor) AudioDSPKernelProcessor::trace(visitor); } -PassOwnPtrWillBeRawPtr<AudioDSPKernel> DelayProcessor::createKernel() +PassOwnPtr<AudioDSPKernel> DelayProcessor::createKernel() { - return adoptPtrWillBeNoop(new DelayDSPKernel(this)); + return adoptPtr(new DelayDSPKernel(this)); } } // namespace blink |
