diff options
| author | nednguyen <nednguyen@google.com> | 2016-03-26 00:30:24 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-26 07:31:51 +0000 |
| commit | 043ab27b4a422d665580b12b588cba2d47afc387 (patch) | |
| tree | 9bdf18779bab1c3e41f8a50e31dd9b731e5e8393 /third_party/WebKit/Source/platform/graphics | |
| parent | ae2b3a4690087a0160600563edc316118efbdec7 (diff) | |
| download | chromium_src-043ab27b4a422d665580b12b588cba2d47afc387.zip chromium_src-043ab27b4a422d665580b12b588cba2d47afc387.tar.gz chromium_src-043ab27b4a422d665580b12b588cba2d47afc387.tar.bz2 | |
Revert of Make GraphicsLayer the DisplayItemClient for scrollbars composited via PaintLayerCompositor. (patchset #6 id:100001 of https://codereview.chromium.org/1825193002/ )
Reason for revert:
Speculative revert: this may cause crash for rasterize_and_record_micro benchmark.
BUG=597391
Original issue's description:
> Make GraphicsLayer the DisplayItemClient for scrollbars composited via PaintLayerCompositor.
>
> Currently, the DisplayItemClient is LayoutScrollbarPart. This has two
> problems: the mapping between the LayoutScrollbarPart and its backing
> is hard to reverse-engineer given the way the scrollbar code is set
> up (LayoutScrollbarPart vs Scrollbar vs ScrollableArea), and the
> fact that LayoutScrollbarPart can be painted in both non-composited
> and composited modes. This distinction is important for computation
> of correct visual rects.
>
> This can be cleaned up by replaying the painted scrollbar content
> with the GraphicsLayer backing as the DisplayItemClient, which
> has the correct visualRect() (i.e. bounds of GraphicsLayer).
>
> BUG=529938
>
> Committed: https://crrev.com/8460ef8fc6125185abc1486eb61b0ca7fc9298ad
> Cr-Commit-Position: refs/heads/master@{#382778}
TBR=chrishtr@chromium.org,wkorman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=529938
Review URL: https://codereview.chromium.org/1839533002
Cr-Commit-Position: refs/heads/master@{#383451}
Diffstat (limited to 'third_party/WebKit/Source/platform/graphics')
| -rw-r--r-- | third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp | 1 | ||||
| -rw-r--r-- | third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp index c5c3db9..1e9b880 100644 --- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp +++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp @@ -101,7 +101,6 @@ static WTF::String specialDrawingTypeAsDebugString(DisplayItem::Type type) DEBUG_STRING_CASE(ScrollbarThumb); DEBUG_STRING_CASE(ScrollbarTickmarks); DEBUG_STRING_CASE(ScrollbarTrackBackground); - DEBUG_STRING_CASE(ScrollbarCompositedScrollbar); DEBUG_STRING_CASE(SelectionTint); DEBUG_STRING_CASE(TableCellBackgroundFromColumnGroup); DEBUG_STRING_CASE(TableCellBackgroundFromColumn); diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h index 2f402fb..2ae4995 100644 --- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h +++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h @@ -92,7 +92,6 @@ public: ScrollbarThumb, ScrollbarTickmarks, ScrollbarTrackBackground, - ScrollbarCompositedScrollbar, SelectionTint, TableCellBackgroundFromColumnGroup, TableCellBackgroundFromColumn, |