diff options
author | kozyatinskiy <kozyatinskiy@chromium.org> | 2016-03-25 22:48:10 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-03-26 05:49:58 +0000 |
commit | e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885 (patch) | |
tree | 607e6aba6d77dc6d4a208d868905edef2589983a /third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h | |
parent | 4cd3a57d676a70d046b3d190a701ecb6db74a112 (diff) | |
download | chromium_src-e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885.zip chromium_src-e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885.tar.gz chromium_src-e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885.tar.bz2 |
[DevTools] Debugger::currentCallFrames returns array instead linked list
We can return array instead linked list since V8JavaScriptCallFrame wrapper was removed.
Method callFrameByIndex was removed because we can use currentCallFrames instead: cached when DevTools is paused and with getter when we check stack trace for DOM breakpoint.
BUG=595206
R=dgozman@chromium.org
Review URL: https://codereview.chromium.org/1838683002
Cr-Commit-Position: refs/heads/master@{#383448}
Diffstat (limited to 'third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h')
-rw-r--r-- | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h index 83213ec..0a96e8e09 100644 --- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h +++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h @@ -32,6 +32,7 @@ #define V8DebuggerImpl_h #include "platform/inspector_protocol/TypeBuilder.h" +#include "platform/v8_inspector/JavaScriptCallFrame.h" #include "platform/v8_inspector/V8DebuggerScript.h" #include "platform/v8_inspector/public/V8Debugger.h" #include "wtf/PassOwnPtr.h" @@ -43,7 +44,6 @@ namespace blink { using protocol::Maybe; -class JavaScriptCallFrame; struct ScriptBreakpoint; class V8DebuggerAgentImpl; class V8RuntimeAgentImpl; @@ -83,10 +83,8 @@ public: void stepOutOfFunction(); void clearStepping(); - bool setScriptSource(const String16& sourceID, const String16& newContent, bool preview, ErrorString*, Maybe<protocol::Debugger::SetScriptSourceError>*, OwnPtr<JavaScriptCallFrame>* newCallFrames, Maybe<bool>* stackChanged); - PassOwnPtr<JavaScriptCallFrame> currentCallFrames(); - PassOwnPtr<JavaScriptCallFrame> callFrame(int index); - int frameCount(); + bool setScriptSource(const String16& sourceID, const String16& newContent, bool preview, ErrorString*, Maybe<protocol::Debugger::SetScriptSourceError>*, JavaScriptCallFrames* newCallFrames, Maybe<bool>* stackChanged); + JavaScriptCallFrames currentCallFrames(int limit = 0); bool isPaused(); v8::Local<v8::Context> pausedContext() { return m_pausedContext; } |