summaryrefslogtreecommitdiffstats
path: root/third_party/WebKit/public/web/WebStorageEventDispatcher.h
diff options
context:
space:
mode:
authordominickn <dominickn@chromium.org>2016-02-26 17:52:53 -0800
committerCommit bot <commit-bot@chromium.org>2016-02-27 01:54:21 +0000
commit9c7ceaa3b757e38ebf6ac5b59516ff54c8f786b6 (patch)
tree85e6cf9daea935b621cb718051ab03f136098ad0 /third_party/WebKit/public/web/WebStorageEventDispatcher.h
parentc48d49d0bf11d3ee777025b5de2c0dbbef3f57a7 (diff)
downloadchromium_src-9c7ceaa3b757e38ebf6ac5b59516ff54c8f786b6.zip
chromium_src-9c7ceaa3b757e38ebf6ac5b59516ff54c8f786b6.tar.gz
chromium_src-9c7ceaa3b757e38ebf6ac5b59516ff54c8f786b6.tar.bz2
Remove WebContentsObserver::DidGetUserGesture.
This CL removes DidGetUserGesture and its various hooks in content/. All existing clients of this method have been migrated to WebContentsObserver::DidGetUserInteraction. This is a follow up to https://crrev.com/1388293002, which implemented WebContentsObserver::DidGetUserInteraction. Compared to DidGetUserGesture, DidGetUserInteraction has a simpler implementation in content/, and signals to clients the type of user interaction which triggered it. DidGetUserGesture was intended to signal the types of gestures which would indicate that the user was attempting to trigger an action (Enter, Space, mouse click, gesture tap). However, gesture signals are always noisy; the download request limiter, external protocol handler, and resource dispatch host (which consumed DidGetUserGesture) treated the gesture as a heuristic, rather than as a canonical indication of a user's intent. In general, it is impossible to know whether any of the user inputs were actually intended to trigger an action. This makes DidGetUserGesture suitable *only* as a heuristic. DidGetUserInteraction is intended as a complete replacement for DidGetUserGesture, except it triggers on all keypress events rather than only Enter and Space. This expansion is appropriate given the aforementioned heuristic-nature of this signal. BUG=584154 Review URL: https://codereview.chromium.org/1735833002 Cr-Commit-Position: refs/heads/master@{#378071}
Diffstat (limited to 'third_party/WebKit/public/web/WebStorageEventDispatcher.h')
0 files changed, 0 insertions, 0 deletions