diff options
| author | bauerb <bauerb@chromium.org> | 2015-06-10 14:06:20 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-06-10 21:06:43 +0000 |
| commit | 04743335609114653560808dda22cb8b09e70670 (patch) | |
| tree | 39228b5b388ccbc111e060c5f6f69e2afca35d0f /third_party/android_platform | |
| parent | 5e00a87e440d23e62082e8fc283d046fd05efa48 (diff) | |
| download | chromium_src-04743335609114653560808dda22cb8b09e70670.zip chromium_src-04743335609114653560808dda22cb8b09e70670.tar.gz chromium_src-04743335609114653560808dda22cb8b09e70670.tar.bz2 | |
Ignore files with non-sane filenames in the Android stack symbolizing tool.
BUG=498683
Review URL: https://codereview.chromium.org/1175033002
Cr-Commit-Position: refs/heads/master@{#333798}
Diffstat (limited to 'third_party/android_platform')
| -rw-r--r-- | third_party/android_platform/README.chromium | 3 | ||||
| -rwxr-xr-x | third_party/android_platform/development/scripts/symbol.py | 3 |
2 files changed, 5 insertions, 1 deletions
diff --git a/third_party/android_platform/README.chromium b/third_party/android_platform/README.chromium index 192b9d6..854a36b 100644 --- a/third_party/android_platform/README.chromium +++ b/third_party/android_platform/README.chromium @@ -26,7 +26,8 @@ include, but are not limited to, the following: Added memoization of addr2line and objdump. Added option to change the amount of symbolization done. Updated output directories to use environment variable. -When calling addr2line, check the symbol is a file (and not a directory). +When calling addr2line, check the symbol is a file that looks like it contains + symbols. Added support for parsing LOG(FATAL) and DCHECK errors and their stack traces, as emitted by src/base/debug/stack_trace_android.cc Added support for finding symbols when library is loaded directly from the APK. diff --git a/third_party/android_platform/development/scripts/symbol.py b/third_party/android_platform/development/scripts/symbol.py index dcb0e77..4cde7d9 100755 --- a/third_party/android_platform/development/scripts/symbol.py +++ b/third_party/android_platform/development/scripts/symbol.py @@ -452,6 +452,9 @@ def CallAddr2LineForSet(lib, unique_addrs): symbols = SYMBOLS_DIR + lib + if not os.path.splitext(symbols)[1] in ['', '.so', '.apk']: + return None + if not os.path.isfile(symbols): return None |