diff options
| author | scottmg@google.com <scottmg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-24 16:16:14 +0000 |
|---|---|---|
| committer | scottmg@google.com <scottmg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-24 16:16:14 +0000 |
| commit | 225507326ae5af8f9cf644aaee91174bd0e3602d (patch) | |
| tree | 2108e1488abb98f566a8c56c386d22f2b1ba0978 /third_party/leveldatabase | |
| parent | f697903c60e1d151b9c4b81c571fce356ee702f0 (diff) | |
| download | chromium_src-225507326ae5af8f9cf644aaee91174bd0e3602d.zip chromium_src-225507326ae5af8f9cf644aaee91174bd0e3602d.tar.gz chromium_src-225507326ae5af8f9cf644aaee91174bd0e3602d.tar.bz2 | |
Revert 153092 - Turn on warnings as errors for (most) third_party code on Windows
Is causing warnings for Official build in PDF code. Boo.
-----------------
Can't quite be fully enabled yet due to not-yet-fixed third party
dependencies. Without it enabled, other packages regress while we're fixing
things. So, add a flag for now so warnings-freeness can be ratcheted forward
by having it on for most packages, but off for a few.
Also, disable warning in qcms (fixed upstream by a large refactoring, not
worth rolling for), and disable two minor warnings in yasm (patch posted
upstream for a few months, but maintainer does not seem motivated to merge).
Fix release-only warning in leveldatabase/env_chromium.cc. Was calling exit(1)
in a leaky destructor.
Fix a warning in lzma_sdk (missing an include).
Disable a silly warning in Release builds of skia and memory_watcher (that
/GS is not working because optimization is disabled).
Warning are currently tolerated in libvpx and mesa.
Cannot be committed until http://chromiumcodereview.appspot.com/10823426/ has
landed.
R=thakis@chromium.org
BUG=126483,140121, 143877
TEST=
Review URL: https://chromiumcodereview.appspot.com/10827429
TBR=scottmg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10872063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153223 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'third_party/leveldatabase')
| -rw-r--r-- | third_party/leveldatabase/env_chromium.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/third_party/leveldatabase/env_chromium.cc b/third_party/leveldatabase/env_chromium.cc index d1b4c26..6056de4 100644 --- a/third_party/leveldatabase/env_chromium.cc +++ b/third_party/leveldatabase/env_chromium.cc @@ -252,7 +252,8 @@ class ChromiumEnv : public Env { public: ChromiumEnv(); virtual ~ChromiumEnv() { - NOTREACHED(); + fprintf(stderr, "Destroying Env::Default()\n"); + exit(1); } virtual Status NewSequentialFile(const std::string& fname, |