diff options
| author | brettw <brettw@chromium.org> | 2015-10-20 20:05:38 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-21 03:06:32 +0000 |
| commit | 011138d7e02ee1c345fa55805ca2c154ca68c1bf (patch) | |
| tree | 71b08f4e1693085f81b37f7f35b0e6b43df05d01 /third_party/libaddressinput | |
| parent | 4c50dbb58688047efbe6b8b86cfb97ee64b7d97a (diff) | |
| download | chromium_src-011138d7e02ee1c345fa55805ca2c154ca68c1bf.zip chromium_src-011138d7e02ee1c345fa55805ca2c154ca68c1bf.tar.gz chromium_src-011138d7e02ee1c345fa55805ca2c154ca68c1bf.tar.bz2 | |
Add more test binaries to GN Mac build.
This adds components_unittests (passes) and components_browsertests (fails with some bundle-related errors).
osmesa should be a loadable_module on Mac. I removed the "lib" prefix from loadable modules on Mac as GYP calls is just "osmesa.so".
Removes a GYP warning exclusion for libaddressinput because Grit no longer generates a file ending with no newline.
Made device's weak_framework parameter two arguments rather than one with a space. GN will escape the space to keep everything together, and this confuses clang.
Review URL: https://codereview.chromium.org/1415783003
Cr-Commit-Position: refs/heads/master@{#355228}
Diffstat (limited to 'third_party/libaddressinput')
| -rw-r--r-- | third_party/libaddressinput/libaddressinput.gyp | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/third_party/libaddressinput/libaddressinput.gyp b/third_party/libaddressinput/libaddressinput.gyp index 3fca856..b9bbbf9 100644 --- a/third_party/libaddressinput/libaddressinput.gyp +++ b/third_party/libaddressinput/libaddressinput.gyp @@ -61,15 +61,6 @@ 'sources!': [ 'src/cpp/src/util/json.cc', ], - 'conditions': [ - ['OS=="mac" or OS=="ios"', { - # localization.cc in libaddressinput_util_files includes - # grit-generated en_messages.cc, which does not have a newline. - 'xcode_settings': { - 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'NO', - }, - }], - ], 'include_dirs': [ 'chromium/override/', 'src/cpp/include/', |