diff options
| author | dtapuska <dtapuska@chromium.org> | 2015-05-01 06:58:25 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-01 14:26:21 +0000 |
| commit | dafcf89b36898f4f4afc010824879290b9e51e3a (patch) | |
| tree | 37abdef8dfe04288c9401a0baf04be28f9118ab4 /third_party/libaddressinput | |
| parent | f75b259d8c304678fe77867b9ca01e9a9e6a202a (diff) | |
| download | chromium_src-dafcf89b36898f4f4afc010824879290b9e51e3a.zip chromium_src-dafcf89b36898f4f4afc010824879290b9e51e3a.tar.gz chromium_src-dafcf89b36898f4f4afc010824879290b9e51e3a.tar.bz2 | |
Adjust URLFetcher::Create API so that object is returned as scoped_ptr.
Most interfaces were storing the object in a scoped_ptr already. This
adjusts the API so that it is a little clearer of the ownership
transfer.
A number of clients put the URLFetcher in a table and do memory
management on it themselves; this is likely templatable code
for a future CL. The scope of this CL was to change the API but
no control flow changes. Making this change found one memory leak;
(http://crbug.com/482459) has been addressed separately.
BUG=371201
TESTS=net_unittests google_api_unittests
TBR=jochen@chromium.org, thakis@chromium.org, oshima@chromium.org, armansito@chromium.org, reillyg@chromium.org, rogerta@chromium.org, stuartmorgan@chromium.org, wez@chromium.org, pavely@chromium.org, rouslan@chromium.org
Review URL: https://codereview.chromium.org/1117703002
Cr-Commit-Position: refs/heads/master@{#327901}
Diffstat (limited to 'third_party/libaddressinput')
| -rw-r--r-- | third_party/libaddressinput/chromium/chrome_metadata_source.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/third_party/libaddressinput/chromium/chrome_metadata_source.cc b/third_party/libaddressinput/chromium/chrome_metadata_source.cc index 51066d9..7ef9b29 100644 --- a/third_party/libaddressinput/chromium/chrome_metadata_source.cc +++ b/third_party/libaddressinput/chromium/chrome_metadata_source.cc @@ -93,8 +93,8 @@ void ChromeMetadataSource::Download(const std::string& key, return; } - scoped_ptr<net::URLFetcher> fetcher( - net::URLFetcher::Create(resource, net::URLFetcher::GET, this)); + scoped_ptr<net::URLFetcher> fetcher = + net::URLFetcher::Create(resource, net::URLFetcher::GET, this); fetcher->SetLoadFlags( net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES); fetcher->SetRequestContext(getter_); |