diff options
author | sgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-18 23:26:29 +0000 |
---|---|---|
committer | sgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-18 23:26:29 +0000 |
commit | b96fc5dc177d311db220dc4039e74a9c0d871558 (patch) | |
tree | 9bbc6ea3af7c0da75d4b6025d4b475dd62eec0b2 /third_party/libevent | |
parent | db8635032b1f83436a072be14e425076a7bd8164 (diff) | |
download | chromium_src-b96fc5dc177d311db220dc4039e74a9c0d871558.zip chromium_src-b96fc5dc177d311db220dc4039e74a9c0d871558.tar.gz chromium_src-b96fc5dc177d311db220dc4039e74a9c0d871558.tar.bz2 |
Convert from using env['PLATFORM'] directly to using the more flexible
and better-thought-out Hammer env.Bits() idioms:
* env['PLATFORM'] == 'win32' => env.Bit('windows')
* env['PLATFORM'] == 'posix' => env.Bit('linux')
* env['PLATFORM'] == 'darwin' => env.Bit('mac')
New idioms:
* env.Bit('posix') => really does mean "any POSIX platform"
* env.AnyBits('mac', 'linux') => specifically mac or linux, excluding
other POSIX platforms
Where we were using compound conditionals (e.g., "env['PLATFORM'] in
('posix', 'darwin')") I tried to take my best shot at translating
the intent (i.e., "env.Bits('posix')" for something POSIX, "not
env.Bits('mac')" for something not yet ported to Mac, etc.)
Review URL: http://codereview.chromium.org/15051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7270 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'third_party/libevent')
-rw-r--r-- | third_party/libevent/libevent.scons | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/third_party/libevent/libevent.scons b/third_party/libevent/libevent.scons index 82e54ce..124f825 100644 --- a/third_party/libevent/libevent.scons +++ b/third_party/libevent/libevent.scons @@ -19,7 +19,7 @@ env.Append( ], ) -if env['PLATFORM'] == 'darwin': +if env.Bit('mac'): env.Prepend( CPPPATH = [ '$LIBEVENT_DIR/generated/', @@ -31,7 +31,7 @@ if env['PLATFORM'] == 'darwin': 'sh ${SOURCES[0]} ${SOURCES[1]}') -if env['PLATFORM'] == 'posix': +if env.Bit('linux'): env.Prepend( CPPPATH = [ '$LIBEVENT_DIR/linux/', @@ -61,13 +61,13 @@ input_files = [ 'strlcpy.c', ] -if env['PLATFORM'] == 'posix': +if env.Bit('linux'): input_files.extend([ 'epoll.c', 'epoll_sub.c', ]) -if env['PLATFORM'] == 'darwin': +if env.Bit('mac'): input_files.extend([ 'kqueue.c', ]) |