diff options
author | ccameron@chromium.org <ccameron@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-01 19:51:04 +0000 |
---|---|---|
committer | ccameron@chromium.org <ccameron@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-01 19:51:04 +0000 |
commit | 36c455852d581784b4181151ce61022de2fc04b7 (patch) | |
tree | 6694607f54ac9e26e100b18177f76fac4d506ceb /third_party/libexif | |
parent | e8b2e42a4e384395c0a0f792cf43a5dc093edc2f (diff) | |
download | chromium_src-36c455852d581784b4181151ce61022de2fc04b7.zip chromium_src-36c455852d581784b4181151ce61022de2fc04b7.tar.gz chromium_src-36c455852d581784b4181151ce61022de2fc04b7.tar.bz2 |
Revert 260917 "Media Galleries API Metadata: Image metadata"
> Media Galleries API Metadata: Image metadata
>
> Enables libexif and uses it to parse some image tags into the GetMetadata call.
>
> BUG=318450
>
> Review URL: https://codereview.chromium.org/191583002
TBR=tommycli@chromium.org
Review URL: https://codereview.chromium.org/217233005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260931 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'third_party/libexif')
-rw-r--r-- | third_party/libexif/libexif.gyp | 43 |
1 files changed, 15 insertions, 28 deletions
diff --git a/third_party/libexif/libexif.gyp b/third_party/libexif/libexif.gyp index 5da9a1f..20aa227 100644 --- a/third_party/libexif/libexif.gyp +++ b/third_party/libexif/libexif.gyp @@ -5,16 +5,15 @@ { 'variables': { 'conditions': [ - ['OS == "linux"', { - 'use_system_libexif%': 1, - }, { # OS != "linux" + # TODO(kmadhusu): We are not ready to build this library on Android. + # Resolve the issues and build on Android. + ['os_posix==1 and OS!="mac"', { + 'use_system_libexif%': 0, + }, { # os_posix != 1 or OS == "mac" 'use_system_libexif%': 0, }], ], }, - 'includes': [ - '../../build/util/version.gypi', - ], 'conditions': [ ['use_system_libexif==0', { 'targets': [ @@ -57,19 +56,6 @@ ], }, 'conditions': [ - ['clang==1', { - 'cflags': [ - '-Wno-enum-conversion', - '-Wno-switch' - ], - 'xcode_settings': { - 'WARNING_CFLAGS': [ - '-Wno-enum-conversion', - '-Wno-switch', - '-Wno-format', - ], - }, - }], ['os_posix==1 and OS!="mac"', { 'cflags!': ['-fvisibility=hidden'], }], @@ -80,25 +66,26 @@ 'mac_real_dsym': 1, }, }], - ], - 'xcode_settings': { + ], + 'xcode_settings': { 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', # no -fvisibility=hidden - 'DYLIB_INSTALL_NAME_BASE': '@rpath', + # TODO(kmadhusu): Copy this dylib to Versions folder. + # (Do something similar to libplugin_carbon_interpose.dylib). + 'DYLIB_INSTALL_NAME_BASE': '@executable_path/../../..', }, }], ['OS=="win"', { 'product_name': 'libexif', - 'sources': [ - 'libexif.def', - ], + 'msvs_settings': { + 'VCLinkerTool': { + 'ModuleDefinitionFile': 'libexif.def', + }, + }, 'defines': [ # This seems like a hack, but this is what WebKit Win does. 'snprintf=_snprintf', 'inline=__inline', ], - 'msvs_disabled_warnings': [ - 4267, # size_t -> ExifLong truncation on amd64 - ], }], ], }, |