diff options
| author | brucedawson <brucedawson@chromium.org> | 2015-04-20 05:09:19 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-20 12:09:29 +0000 |
| commit | 548cc22b487981ecd15a2e0b869a15309446e6f4 (patch) | |
| tree | 70b757c3d5eae0beb664d8d5bdab8a6c39b743ba /third_party/libxml/README.chromium | |
| parent | d889e2265a81261930ad8ecd96b929612321f57e (diff) | |
| download | chromium_src-548cc22b487981ecd15a2e0b869a15309446e6f4.zip chromium_src-548cc22b487981ecd15a2e0b869a15309446e6f4.tar.gz chromium_src-548cc22b487981ecd15a2e0b869a15309446e6f4.tar.bz2 | |
Fix errors caused by illegal #define of snprintf.
Because VS has, for a long time, not had snprintf some developers have
fixed this with #define snprintf _snprintf. This is scary because the
two functions behave differently, and it also breaks with VS 2015 which
does implement snprintf. So, the #defines all need a version check.
The errors are:
stdio.h(1926): warning C4005: 'snprintf': macro redefinition
libxml\win32\config.h(98): note: see previous definition of 'snprintf'
libxml\src\include\win32config.h(98): note: see previous def of 'snprintf'
stdio.h(1929): fatal error C1189: #error: Macro definition of snprintf
conflicts with Standard Library function declaration
R=cpu@chromium.org
BUG=440500
Review URL: https://codereview.chromium.org/1072653003
Cr-Commit-Position: refs/heads/master@{#325832}
Diffstat (limited to 'third_party/libxml/README.chromium')
| -rw-r--r-- | third_party/libxml/README.chromium | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/third_party/libxml/README.chromium b/third_party/libxml/README.chromium index bfdff5b..f12d267 100644 --- a/third_party/libxml/README.chromium +++ b/third_party/libxml/README.chromium @@ -29,6 +29,7 @@ Modifications: - Add helper classes in chromium/libxml_utils.cc and chromium/include/libxml/libxml_utils.h. - Add a tweak to limit problems caused by excessive strings and buffers. - Change the xmlNs struct a little bit, so it looks like it has no children +- Prevent snprintf from being defined as _snprintf on VS 2015. if treated as a generic xmlNode object. - Fix pretty harmless use-after-free in generate-id function. - Merge a clang warning fix http://git.gnome.org/browse/libxml2/commit/?id=713434d2309da469d64b35e163ea6556dadccada |