diff options
| author | brucedawson <brucedawson@chromium.org> | 2016-03-07 21:13:41 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-03-08 05:15:09 +0000 |
| commit | f7bd300e8c52d6ebb7575a28d4cd9d3bdccaf439 (patch) | |
| tree | 5977337cc5853cfa089f07ca8124e5bf596f976b /third_party/libxml/README.chromium | |
| parent | 94326b75fc5b320ff478e82023c1c4296a83750e (diff) | |
| download | chromium_src-f7bd300e8c52d6ebb7575a28d4cd9d3bdccaf439.zip chromium_src-f7bd300e8c52d6ebb7575a28d4cd9d3bdccaf439.tar.gz chromium_src-f7bd300e8c52d6ebb7575a28d4cd9d3bdccaf439.tar.bz2 | |
Avoid illegal definition of snprintf in VS 2015
VS 2015 supplies an implementation of snprintf which makes definining
it to _snprintf illegal - previously it was just a really bad idea.
This reinstates the compiler version check so that libxml will compile
in Chromium.
README.chromium was also updated to make it explicit that these checks
need to be added (for now) when config.h is copied.
A corresponding change will need to be made upstream.
BUG=440500,591920
Review URL: https://codereview.chromium.org/1770093002
Cr-Commit-Position: refs/heads/master@{#379755}
Diffstat (limited to 'third_party/libxml/README.chromium')
| -rw-r--r-- | third_party/libxml/README.chromium | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/third_party/libxml/README.chromium b/third_party/libxml/README.chromium index c3536ee..33d9f98 100644 --- a/third_party/libxml/README.chromium +++ b/third_party/libxml/README.chromium @@ -36,6 +36,9 @@ On a Windows box: cd libxml2-2.9.2\win32 cscript //E:jscript configure.js compiler=msvc iconv=no icu=yes ftp=no http=no Then copy VC10/config.h and include/libxml/xmlversion.h to win32/ on Linux. +Patch win32/config.h to wrap the #define snprintf with: + #if _MSC_VER < 1900 + #endif Remove: src/doc/ |