diff options
| author | ccameron <ccameron@chromium.org> | 2015-07-27 18:06:12 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-28 01:07:10 +0000 |
| commit | 4bf2ca554347fc20e1649e5ff4cf700d9fbd713a (patch) | |
| tree | b582809e966c8d13a3f55cbc2f0c708ebb240d4e /third_party/libxml | |
| parent | 3e4cf54491803eb102c4887f1de5ccd088c612b1 (diff) | |
| download | chromium_src-4bf2ca554347fc20e1649e5ff4cf700d9fbd713a.zip chromium_src-4bf2ca554347fc20e1649e5ff4cf700d9fbd713a.tar.gz chromium_src-4bf2ca554347fc20e1649e5ff4cf700d9fbd713a.tar.bz2 | |
Revert of Enable C4018 globally for the GN build, and disable per-target. (patchset #4 id:60001 of https://codereview.chromium.org/1246103007/)
Reason for revert:
Speculative revert based on windows gn bots failing with
http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/10113
FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/base/base/precompile.c.obj.rsp /c ../../build/precompile.cc /Foobj/base/base/precompile.c.obj /Fdobj/base/base_c.pdb
e:\b\build\slave\win_x64_gn__dbg_\build\src\build\precompile.cc(8) : error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_x64_gn__dbg_\build\src\build\precompile.cc(8) : warning C4206: nonstandard extension used : translation unit is empty
ninja: build stopped: subcommand failed.
In theory this warning shouldn't have affected other warnings, but there are no other clear candidates.
Original issue's description:
> Enable C4018 globally for the GN build, and disable per-target.
>
> This matches what the GYP build does.
>
> BUG=398202
> TEST=none
>
> Committed: https://crrev.com/d408e1965f8e03629738039289ab7779c42a318c
> Cr-Commit-Position: refs/heads/master@{#340590}
TBR=brettw@chromium.org,erg@chromium.org,pkasting@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=398202
Review URL: https://codereview.chromium.org/1257583007
Cr-Commit-Position: refs/heads/master@{#340623}
Diffstat (limited to 'third_party/libxml')
| -rw-r--r-- | third_party/libxml/BUILD.gn | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/third_party/libxml/BUILD.gn b/third_party/libxml/BUILD.gn index 58a5f1c..1f10dee 100644 --- a/third_party/libxml/BUILD.gn +++ b/third_party/libxml/BUILD.gn @@ -155,10 +155,7 @@ static_library("libxml") { ] if (is_win) { - cflags_c = [ - "/wd4018", # Signed/unsigned mismatch in comparison. - "/wd4101", # Unreferenced local variable. - ] + cflags_c = [ "/wd4101" ] # Unreferenced local variable. } else if (is_mac || is_ios || is_android) { # http://www.xmlsoft.org/threads.html says that this is required when using # libxml from several threads, which can possibly happen in chrome. On |