diff options
| author | brettw <brettw@chromium.org> | 2015-08-31 13:41:43 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-31 20:42:50 +0000 |
| commit | 4af2eac8e84692d94f88504ab6e0b244b88dddcb (patch) | |
| tree | 216e4c278ec0aa4ad07ab82cac8b19157de503db /third_party/usrsctp | |
| parent | 41f132e4a0ed599b090ec1070451d970cb5bbbf4 (diff) | |
| download | chromium_src-4af2eac8e84692d94f88504ab6e0b244b88dddcb.zip chromium_src-4af2eac8e84692d94f88504ab6e0b244b88dddcb.tar.gz chromium_src-4af2eac8e84692d94f88504ab6e0b244b88dddcb.tar.bz2 | |
Un-nest configs in GN files.
People sometimes nest targets or configs, usually with the assumption that this limits the visibility of a config to within a target. But this nesting provides no visibility restrictions over declaring it outside of a block.
Un-nest for clarity.
Review URL: https://codereview.chromium.org/1318823008
Cr-Commit-Position: refs/heads/master@{#346461}
Diffstat (limited to 'third_party/usrsctp')
| -rw-r--r-- | third_party/usrsctp/BUILD.gn | 21 |
1 files changed, 12 insertions, 9 deletions
diff --git a/third_party/usrsctp/BUILD.gn b/third_party/usrsctp/BUILD.gn index bbea24b..3accc19 100644 --- a/third_party/usrsctp/BUILD.gn +++ b/third_party/usrsctp/BUILD.gn @@ -11,6 +11,13 @@ config("usrsctp_config") { ] } +config("usrsctp_warnings") { + if (is_clang) { + # atomic_init in user_atomic.h is a static function in a header. + cflags = [ "-Wno-unused-function" ] + } +} + static_library("usrsctp") { sources = [ "usrsctplib/netinet/sctp.h", @@ -84,16 +91,12 @@ static_library("usrsctp") { # "SCTP_DEBUG", # Uncomment for SCTP debugging. ] - config("usrsctp_warnings") { - if (is_clang) { - # atomic_init in user_atomic.h is a static function in a header. - cflags = [ "-Wno-unused-function" ] - } - } configs -= [ "//build/config/compiler:chromium_code" ] - configs += [ "//build/config/compiler:no_chromium_code" ] - configs += [ "//build/config/compiler:no_incompatible_pointer_warnings" ] - configs += [ ":usrsctp_warnings" ] + configs += [ + ":usrsctp_warnings", + "//build/config/compiler:no_chromium_code", + "//build/config/compiler:no_incompatible_pointer_warnings", + ] public_configs = [ ":usrsctp_config" ] |