diff options
| author | haraken@chromium.org <haraken@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-24 07:49:45 +0000 |
|---|---|---|
| committer | haraken@chromium.org <haraken@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-24 07:49:45 +0000 |
| commit | 9187f728e1842a650b9bd5541335ffabaf505fa7 (patch) | |
| tree | 6dfba50532e24edc3c67b8042cbf2b51ab469c25 /third_party/webdriver | |
| parent | e736e81b857a78fd473aa435747db6fb69b8a5ea (diff) | |
| download | chromium_src-9187f728e1842a650b9bd5541335ffabaf505fa7.zip chromium_src-9187f728e1842a650b9bd5541335ffabaf505fa7.tar.gz chromium_src-9187f728e1842a650b9bd5541335ffabaf505fa7.tar.bz2 | |
Revert 252883 "Remove tests and code for showModalDialog"
This CL broke show-modal-dialog tests in Blink.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/dom/Window/open-window-min-size.html,fast/events/scroll-event-during-modal-dialog.html,fast/events/show-modal-dialog-onblur-onfocus.html,fast/harness/show-modal-dialog.html
> Remove tests and code for showModalDialog
>
> This deletes the chromium-side implementation logic and a few tests for
> showModalDialog. I believe more simplification is possible to do without the
> design constraints imposed by showModalDialog but we should probably start
> small in case we run into unexpected compat issues.
>
> R=darin
> BUG=345831
>
> Review URL: https://codereview.chromium.org/165793003
TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/177263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252889 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'third_party/webdriver')
| -rw-r--r-- | third_party/webdriver/test_data/alerts.html | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/third_party/webdriver/test_data/alerts.html b/third_party/webdriver/test_data/alerts.html index 58cf0b9..3ae831b 100644 --- a/third_party/webdriver/test_data/alerts.html +++ b/third_party/webdriver/test_data/alerts.html @@ -46,6 +46,8 @@ <p>This is a test of a confirm: <a href="simpleTest.html" id="confirm" onclick="return confirm('Are you sure?');">test confirm</a></p> +<p>This is a test of showModalDialog: <a href="#" id="dialog" onclick="showModalDialog('javascriptPage.html')">test dialog</a></p> + <p>This is a test of an alert in an iframe: <iframe src="iframeWithAlert.html" name="iframeWithAlert"></iframe> </p> |