diff options
| author | brucedawson <brucedawson@chromium.org> | 2015-06-22 15:37:30 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-06-22 22:39:21 +0000 |
| commit | 8a019cccd65c94b3156ed57322d264ae04aa115e (patch) | |
| tree | f802e10cf36951ffffb47d05d74a3300591a8e55 /third_party/yasm | |
| parent | f3bcf1be3bd482be9bcf4db1793e94f42f7c2fef (diff) | |
| download | chromium_src-8a019cccd65c94b3156ed57322d264ae04aa115e.zip chromium_src-8a019cccd65c94b3156ed57322d264ae04aa115e.tar.gz chromium_src-8a019cccd65c94b3156ed57322d264ae04aa115e.tar.bz2 | |
Use /analyze:WX- instead of /WX- - avoids 3925 D9025 warnings.
When building with /analyze there are, inevitably, thousands of
warnings. Since going /analyze warning-free is a non-goal we can't
have warnings be errors. This was previously handled by overriding
the /WX setting with /WX- but this worked patchily and led to lots
of these D9025 warnings:
cl : Command line warning D9025 : overriding '/WX' with '/WX-'
I just discovered that /analyze:WX- can be used to say that /analyze
warnings should not be treated as errors. This avoids contradicting
/WX and therefore avoids the 3925 D9025 warnings. This makes the raw
results much easier to look through.
This change necessitates updating the /analyze exclusions in libexif
and yasm - running /analyze on those projects causes internal
compiler errors.
BUG=427616
R=scottmg@chromium.org,thestig@chromium.org,dalecurtis@chromium.org
Review URL: https://codereview.chromium.org/1177153007
Cr-Commit-Position: refs/heads/master@{#335578}
Diffstat (limited to 'third_party/yasm')
| -rw-r--r-- | third_party/yasm/yasm.gyp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/third_party/yasm/yasm.gyp b/third_party/yasm/yasm.gyp index ee03c8f..e02124a 100644 --- a/third_party/yasm/yasm.gyp +++ b/third_party/yasm/yasm.gyp @@ -93,7 +93,7 @@ # https://connect.microsoft.com/VisualStudio/feedback/details/1014799/internal-compiler-error-when-using-analyze 'msvs_settings': { 'VCCLCompilerTool': { - 'AdditionalOptions!': [ '/analyze' ] + 'AdditionalOptions!': [ '/analyze:WX-' ] }, }, }], |