diff options
| author | brettw <brettw@chromium.org> | 2014-09-06 14:21:02 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-06 21:23:45 +0000 |
| commit | 9af4262ad8020658ee04c07d13a2617af64147b1 (patch) | |
| tree | 8c3164713a5fada119ae7d8ad8bc888000829719 /third_party/yasm | |
| parent | 0d9c77423b7733dfa7f3cf4545a2884a1379400b (diff) | |
| download | chromium_src-9af4262ad8020658ee04c07d13a2617af64147b1.zip chromium_src-9af4262ad8020658ee04c07d13a2617af64147b1.tar.gz chromium_src-9af4262ad8020658ee04c07d13a2617af64147b1.tar.bz2 | |
Convert GN visibility variables to lists.
Currently this is either a list or a string. However, this is causing some problems because templates can't add to the invoker's visibility list without knowing if the original is a string or a list.
In an effort to make this consistent, I'm converting all visibiltiy to be lists, and will remove support for strings in a future build.
This exempts cld from header checking since it was confusing GN's header checker. It adds a ppapi header target as well that will be used by libyuv (that requires a roll).
TBR=scottmg
Review URL: https://codereview.chromium.org/544423002
Cr-Commit-Position: refs/heads/master@{#293638}
Diffstat (limited to 'third_party/yasm')
| -rw-r--r-- | third_party/yasm/yasm_assemble.gni | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/third_party/yasm/yasm_assemble.gni b/third_party/yasm/yasm_assemble.gni index 5dc4c7c..78037b8 100644 --- a/third_party/yasm/yasm_assemble.gni +++ b/third_party/yasm/yasm_assemble.gni @@ -110,7 +110,8 @@ template("yasm_assemble") { source_set_name = target_name action_foreach(action_name) { - visibility = ":$source_set_name" # Only the source set can depend on this. + # Only the source set can depend on this. + visibility = [ ":$source_set_name" ] script = "//third_party/yasm/run_yasm.py" sources = invoker.sources |