diff options
| author | robert.bradford <robert.bradford@intel.com> | 2014-10-23 08:05:30 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-23 15:05:47 +0000 |
| commit | ca54b3014721cdc27e4a17dd2c82fe5811fa39cc (patch) | |
| tree | bbb3d90b8e0df8969e6abea9d58e7ff9d6895964 /third_party/zlib/README.chromium | |
| parent | ad9d73a39a02b67b5b26fbe920c1bbd6be20e0d9 (diff) | |
| download | chromium_src-ca54b3014721cdc27e4a17dd2c82fe5811fa39cc.zip chromium_src-ca54b3014721cdc27e4a17dd2c82fe5811fa39cc.tar.gz chromium_src-ca54b3014721cdc27e4a17dd2c82fe5811fa39cc.tar.bz2 | |
Revert of Integrate SIMD optimisations for zlib (patchset #14 id:280001 of https://codereview.chromium.org/552123005/)
Reason for revert:
Strong candidate for: multiple Linux MSan test failures with:
SUMMARY: MemorySanitizer: use-of-uninitialized-value ??:0 ??
Including: CompressionUtilsTest.GzipCompression
Original issue's description:
> Integrate SIMD optimisations for zlib
>
> These optimisations have been published on zlib mailing list and at
> https://github.com/jtkukunas/zlib/
>
> This change merges the following optimisation patches:
> - "For x86, add CPUID check."
> - "Adds SSE2 optimized hash shifting to fill_window."
> - "add SSE4.2 optimized hash function"
> - "add PCLMULQDQ optimized CRC folding"
>
> From Jim Kukunas <james.t.kukunas@linux.intel.com> and adapts them to the
> current zlib version in Chromium.
>
> The optimisations are enabled at runtime if all the necessary CPU features are
> present. As the optimisations require extra cflags to enable the compiler to
> use the instructions the optimisations are held in their own static library
> with a stub implementation to allow linking on other platforms.
>
> TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance
> improvement seen on RoboHornet benchmark on Linux Desktop
> BUG=401517
>
> Committed: https://crrev.com/e045ec106de29562ae94eafccde49a7b73848471
> Cr-Commit-Position: refs/heads/master@{#300866}
TBR=agl@chromium.org,nathan.d.ciobanu@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=401517
Review URL: https://codereview.chromium.org/671163003
Cr-Commit-Position: refs/heads/master@{#300889}
Diffstat (limited to 'third_party/zlib/README.chromium')
| -rw-r--r-- | third_party/zlib/README.chromium | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/third_party/zlib/README.chromium b/third_party/zlib/README.chromium index b90bcff..c9e06ba 100644 --- a/third_party/zlib/README.chromium +++ b/third_party/zlib/README.chromium @@ -19,19 +19,3 @@ The 'google.patch' file represents our changes from the original zlib-1.2.5. A more significant change to support mixed-source data compression. See crbug.com/139744 and mixed-source.patch. - -Integrated Intel SIMD optimisations from: https://github.com/jtkukunas/zlib/ -and modified to accomodate the older version and existing changes in tree. - -This introduces new files: simd_stub.c, crc_folding.c, fill_window_sse.c and -x86.[ch]. All but the latter are built into a static library to allow the -compiler to use the desired instructions only when valid. The latter version is -only built on x86 (32-bit and 64-bit) systems with it's functionality stubbed -on the others. - -Other changes to accomodate: -- fill_window() implementation calls into _sse() variant when supported and the - original implementation renamed to _c() -- read_buf was moved from local to ZLIB_INTERNAL for fill_window_sse.c to use -- INSERT_STRING macro was made a function, insert_string() and an implementation using CRC instruction added -- some crc funcionality moved into crc32.c |