diff options
| author | mnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-11 14:53:53 +0000 |
|---|---|---|
| committer | mnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-11 14:53:53 +0000 |
| commit | b6479186b76882ab8ff8ae5bf137c4952a8c0a71 (patch) | |
| tree | 22b35ba4f35638cd56cfd5cd815772abb770b11e /third_party | |
| parent | 0eb25c4f9e53e59eb652b1d1b44a72dbb5c36de2 (diff) | |
| download | chromium_src-b6479186b76882ab8ff8ae5bf137c4952a8c0a71.zip chromium_src-b6479186b76882ab8ff8ae5bf137c4952a8c0a71.tar.gz chromium_src-b6479186b76882ab8ff8ae5bf137c4952a8c0a71.tar.bz2 | |
Revert 95907 - Clean up SSL false start blacklist code. Numerous changes, including:
* Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
* Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them.
* Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
* Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
* Avoid #define and "using".
* Use standard algorithms for similar reasons as using string ops.
* Use file_util functions to significantly abbreviate file reading/writing code.
* Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
* Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
* Convert non-error uses of stderr to the chrome-standard VLOG(1).
* Correctly handle hostnames with trailing dots in the input file.
* In general, shorten code where possible.
Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7550002
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7623015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96391 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'third_party')
| -rw-r--r-- | third_party/libevent/libevent.gyp | 1 | ||||
| -rw-r--r-- | third_party/modp_b64/modp_b64.gyp | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/third_party/libevent/libevent.gyp b/third_party/libevent/libevent.gyp index 5d4d497..43cdaf2 100644 --- a/third_party/libevent/libevent.gyp +++ b/third_party/libevent/libevent.gyp @@ -13,7 +13,6 @@ 'target_name': 'libevent', 'product_name': 'event', 'type': 'static_library', - 'toolsets': ['host', 'target'], 'sources': [ 'buffer.c', 'evbuffer.c', diff --git a/third_party/modp_b64/modp_b64.gyp b/third_party/modp_b64/modp_b64.gyp index baed111..35c0a99 100644 --- a/third_party/modp_b64/modp_b64.gyp +++ b/third_party/modp_b64/modp_b64.gyp @@ -7,7 +7,6 @@ { 'target_name': 'modp_b64', 'type': 'static_library', - 'toolsets': ['host', 'target'], 'sources': [ 'modp_b64.cc', 'modp_b64.h', |