diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-27 14:57:30 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-27 14:57:30 +0000 |
commit | 69be31fa4cadd7423e74b65682b32482e1162b68 (patch) | |
tree | 2c25a8b60453bdc5ea5fe3e665ad168cd94fe8df /tools/bisect-builds.py | |
parent | bb94ec50e95a0a496d5520409336efc6e1bdd057 (diff) | |
download | chromium_src-69be31fa4cadd7423e74b65682b32482e1162b68.zip chromium_src-69be31fa4cadd7423e74b65682b32482e1162b68.tar.gz chromium_src-69be31fa4cadd7423e74b65682b32482e1162b68.tar.bz2 |
Remove kEnablePrintPreview now that the pdf plugin is part of Chromium.
R=thestig@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272587
Review URL: https://codereview.chromium.org/296453015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272972 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/bisect-builds.py')
-rwxr-xr-x | tools/bisect-builds.py | 25 |
1 files changed, 4 insertions, 21 deletions
diff --git a/tools/bisect-builds.py b/tools/bisect-builds.py index 68a189d..bc65566 100755 --- a/tools/bisect-builds.py +++ b/tools/bisect-builds.py @@ -62,7 +62,7 @@ class PathContext(object): """A PathContext is used to carry the information used to construct URLs and paths when dealing with the storage server and archives.""" def __init__(self, base_url, platform, good_revision, bad_revision, - is_official, is_aura, flash_path = None, pdf_path = None): + is_official, is_aura, flash_path = None): super(PathContext, self).__init__() # Store off the input parameters. self.base_url = base_url @@ -72,7 +72,6 @@ class PathContext(object): self.is_official = is_official self.is_aura = is_aura self.flash_path = flash_path - self.pdf_path = pdf_path # The name of the ZIP file in a revision directory on the server. self.archive_name = None @@ -363,7 +362,7 @@ def RunRevision(context, revision, zipfile, profile, num_runs, command, args): # Run the build as many times as specified. testargs = ['--user-data-dir=%s' % profile] + args # The sandbox must be run as root on Official Chrome, so bypass it. - if ((context.is_official or context.flash_path or context.pdf_path) and + if ((context.is_official or context.flash_path) and context.platform.startswith('linux')): testargs.append('--no-sandbox') if context.flash_path: @@ -373,10 +372,6 @@ def RunRevision(context, revision, zipfile, profile, num_runs, command, args): # pass the correct version we just spoof it. testargs.append('--ppapi-flash-version=99.9.999.999') - if context.pdf_path: - shutil.copy(context.pdf_path, os.path.dirname(context.GetLaunchPath())) - testargs.append('--enable-print-preview') - runcommand = [] for token in shlex.split(command): if token == "%a": @@ -469,7 +464,6 @@ def Bisect(base_url, try_args=(), profile=None, flash_path=None, - pdf_path=None, interactive=True, evaluate=AskIsGoodBuild): """Given known good and known bad revisions, run a binary search on all @@ -506,7 +500,7 @@ def Bisect(base_url, profile = 'profile' context = PathContext(base_url, platform, good_rev, bad_rev, - official_builds, is_aura, flash_path, pdf_path) + official_builds, is_aura, flash_path) cwd = os.getcwd() print "Downloading list of known revisions..." @@ -755,12 +749,6 @@ def main(): 'binary to be used in this bisection (e.g. ' + 'on Windows C:\...\pepflashplayer.dll and on Linux ' + '/opt/google/chrome/PepperFlash/libpepflashplayer.so).') - parser.add_option('-d', '--pdf_path', type = 'str', - help = 'Absolute path to a recent PDF pluggin ' + - 'binary to be used in this bisection (e.g. ' + - 'on Windows C:\...\pdf.dll and on Linux ' + - '/opt/google/chrome/libpdf.so). Option also enables ' + - 'print preview.') parser.add_option('-g', '--good', type = 'str', help = 'A good revision to start bisection. ' + 'May be earlier or later than the bad revision. ' + @@ -831,11 +819,6 @@ def main(): msg = 'Could not find Flash binary at %s' % flash_path assert os.path.exists(flash_path), msg - if opts.pdf_path: - pdf_path = opts.pdf_path - msg = 'Could not find PDF binary at %s' % pdf_path - assert os.path.exists(pdf_path), msg - if opts.official_builds: good_rev = LooseVersion(good_rev) bad_rev = LooseVersion(bad_rev) @@ -852,7 +835,7 @@ def main(): (min_chromium_rev, max_chromium_rev) = Bisect( base_url, opts.archive, opts.official_builds, opts.aura, good_rev, bad_rev, opts.times, opts.command, args, opts.profile, opts.flash_path, - opts.pdf_path, not opts.not_interactive) + not opts.not_interactive) # Get corresponding blink revisions. try: |