summaryrefslogtreecommitdiffstats
path: root/tools/bisect-perf-regression.py
diff options
context:
space:
mode:
authorsimonhatch@chromium.org <simonhatch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-22 18:30:34 +0000
committersimonhatch@chromium.org <simonhatch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-22 18:30:34 +0000
commit8cef993adaf14fb9bc6ce5f924255503c2f90cc7 (patch)
tree973335913510fbf319c27c26beb1a6d218d23ef3 /tools/bisect-perf-regression.py
parent7ea342c0f4613e501b0d863068ed0a3c8947de2f (diff)
downloadchromium_src-8cef993adaf14fb9bc6ce5f924255503c2f90cc7.zip
chromium_src-8cef993adaf14fb9bc6ce5f924255503c2f90cc7.tar.gz
chromium_src-8cef993adaf14fb9bc6ce5f924255503c2f90cc7.tar.bz2
Output std err as percent. Previously, std error was just being displayed as is but the output makes it look like it's being expressed as a % change.
Here's an example of the confusing output: Tested commits: Depot Commit SHA Mean Std. Error State chromium d1ec3f7f30d07132bf0f75e4938d50a508bc7637 88693362.94 +-89200.54 Bad chromium 737540d94a6d97afcf9ff780c10417886b8ed145 89197592.98 +-464098.05 Bad chromium 730f3062b316f9c1f18284357f5f670013a02ee9 89244330.67 +-360230.50 Bad chromium c3b4ba8f43dd89cb62ae5d82db8be245e61f17ae 89132646.40 +-360226.98 Bad chromium 5d03cedb6ace85bf9e227c84e7b40d77d1d39844 89225216.00 +-95084.90 Bad chromium 31c4144f6a642d953d2b7f7b25bf9d597be3c36b 89085952.00 +-438774.78 Bad chromium 657be329489e70fb8237db4f40726794ad224bdf 89262013.94 +-86984.39 Suspected CL chromium 3e1c741eaf73c7391972e50f03c139bba74661fd 78078192.94 +-1128824.27 Good chromium fb7a295a9cec4b1c4824842d2c80d6cc1487d736 78248323.46 +-1112737.96 Good chromium 66283c1ad3028d943c9cc7a32e4f37e967492f9c 76246295.27 +-903342.37 Good chromium 34a3d3736598bc54f1f1cc7383c9d5c99e4bc57e 76418092.52 +-864243.39 Good Average step time: 0:20:14 Approximate size of regression: 11.36%, +-414705.17% std. err Confidence in Bisection Results: 100% BUG=297828 NOTRY=true Review URL: https://codereview.chromium.org/35653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230168 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/bisect-perf-regression.py')
-rwxr-xr-xtools/bisect-perf-regression.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
index 0d01def..ee6498f 100755
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -2278,8 +2278,9 @@ class BisectPerformanceMetrics(object):
regression_size = math.fabs(max(mean_of_good_runs, mean_of_bad_runs) /
max(0.0001, min(mean_of_good_runs, mean_of_bad_runs))) * 100.0 - 100.0
- regression_std_err = CalculatePooledStandardError(
- [working_mean, broken_mean])
+ regression_std_err = math.fabs(CalculatePooledStandardError(
+ [working_mean, broken_mean]) /
+ max(0.0001, min(mean_of_good_runs, mean_of_bad_runs))) * 100.0
print
print 'Average step time: %s' % datetime.timedelta(